Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger plot updates whenever commit data changes #3715

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Apr 19, 2023

2/2 main <- #3665 <- this

This PR ensures that plots diff is recalled when a branch's data changes. I.e when a user makes a commit or runs git reset.

Demo

Screen.Recording.2023-04-19.at.4.30.39.pm.mov

@mattseddon mattseddon added the bug Something isn't working label Apr 19, 2023
@mattseddon mattseddon self-assigned this Apr 19, 2023
@mattseddon mattseddon changed the base branch from main to integrate-exp-show April 19, 2023 09:41
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 37090 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Apr 19, 2023

Code Climate has analyzed commit cac5266 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 94.5% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mattseddon mattseddon merged commit 6f3fd93 into integrate-exp-show Apr 19, 2023
@mattseddon mattseddon deleted the trigger-update-for-moved-head branch April 19, 2023 21:27
mattseddon added a commit that referenced this pull request Apr 20, 2023
…outside the workspace) (#3665)

* wrap all loose test data in test data generator

* add new type

* duplicate required functions but use new data

* update test fixtures

* deduplicate functions

* remove checkpoints model and file system watcher (#3684)

* extend timeout of run experiment test (e2e) (#3713)

* prevent plotting of running experiments (#3712)

* trigger plot updates whenever commit data changes (#3715)

* update demo project and min required version of DVC

* fix experiment id for commits (shown in plots) (#3724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants