Bump min DVC version to 2.55.0 (live metrics for experiments running outside the workspace) #3665
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -429,70 +433,6 @@ describe('collectColumns', () => { | |||
|
|
|||
| expect(onlyHasPrimitiveChild).toBeUndefined() | |||
| }) | |||
|
|
|||
| it('should collect all params and metrics from the test fixture', () => { | |||
| expect(collectColumns(outputFixture).map(({ path }) => path)).toStrictEqual( | |||
There was a problem hiding this comment.
[F] This is a duplicate of should return a value equal to the columns fixture when given the output fixture
mattseddon
force-pushed
the
integrate-exp-show
branch
from
cdd871a to
2bbe80f
Compare
| @@ -1,12 +1,14 @@ | |||
| import { commands } from 'vscode' | |||
There was a problem hiding this comment.
[F] This patch is going away very shortly. I had to resist the urge to just delete it for now.
| @@ -58,17 +58,3 @@ export const collectFiles = ( | |||
|
|
|||
| return uniqueValues(acc) | |||
| } | |||
|
|
|||
| export const collectMetricsFiles = ( | |||
There was a problem hiding this comment.
[F] Encapsulated this back in Experiments
| @@ -1081,9 +1086,9 @@ describe('App', () => { | |||
| renderTableWithoutRunningExperiments() | |||
|
|
|||
| clickRowCheckbox('4fb124a') | |||
| clickRowCheckbox('1ba7bcd', true) | |||
There was a problem hiding this comment.
[F] This label no longer exists, the label is now "workspace" as per experiments running in the workspace.
There was a problem hiding this comment.
[I] We should wrap these somewhere so they are easier to change if we ever have to do it again.
| } from '../../../cli/dvc/contract' | ||
| import { | ||
| buildMetricOrParamPath, | ||
| FILE_SEPARATOR, | ||
| METRIC_PARAM_SEPARATOR | ||
| } from '../paths' | ||
|
|
||
| export const typedValueTreeEntries = (value: NonNullable<ValueTree>) => |
There was a problem hiding this comment.
[F] No longer need this now the types have been fixed... or TypeScript can handle typing object entries now.
mattseddon
changed the title
mattseddon
changed the title
|
Code Climate has analyzed commit b2c2835 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 94.4% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.0% change). View more on Code Climate. |
This PR accounts for the upcoming breaking change in the
exp showdata (iterative/dvc#9170). Please review this PR. I'll be raising follow-ups and merging in (much like #3585).What this PR currently does:
{data: {meta: hasCheckpoints}}(Remove checkpoints model and file system watcher #3684)Clicking on workspace should select the running experiment not the other way around (Fix auto-selection of running experiments #3705)Makes it impossible to select running experiments (causes plots diff to crash exp: refactor show behavior dvc#9170 (comment) & Prevent plotting of running experiments #3712)follow-ups
Drop the custom implementation of the studio client. I.e remove exp push patch (Use exp push to share experiments to Studio #3701 - Do not merge until this release: remove feature flags for experiment sharing dvc#9257 released).
Revisit fields sent to plots webview (e.g revision, id, group, should be standardised). Standardise how experiment name/rev are displayed (Match the way Studio displays experiment name information in the table #3723 & Standardize how experiment information is displayed in plots ribbon #3725).
Fix plots test fixture as experiment running in the workspace should not be selectable: