Prevent plotting of running experiments #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 448afda and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 94.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.0% change). View more on Code Climate. |
mattseddon
commented
Apr 19, 2023
| @@ -217,15 +222,6 @@ export class Experiments extends BaseRepository<TableData> { | |||
| public toggleExperimentStatus( | |||
| id: string | |||
| ): Color | typeof UNSELECTED | undefined { | |||
| if ( | |||
There was a problem hiding this comment.
[F] Moved this down into the model so that all of the logic is together.
mattseddon
commented
Apr 19, 2023
| @@ -353,8 +349,10 @@ export class Experiments extends BaseRepository<TableData> { | |||
| return this.experiments.getWorkspaceCommitsAndExperiments() | |||
| } | |||
|
|
|||
| public async selectExperiments() { | |||
| const experiments = this.experiments.getWorkspaceCommitsAndExperiments() | |||
| public async selectExperimentsToPlot() { | |||
There was a problem hiding this comment.
[F] This is the only thing this function is used for so I think the name better explains the usage
mattseddon
commented
Apr 19, 2023
| @@ -2072,121 +2099,4 @@ suite('Experiments Test Suite', () => { | |||
| expect(mockUpdateExperimentsData).to.be.calledOnce | |||
| }) | |||
| }) | |||
|
|
|||
| describe('checkForFinishedWorkspaceExperiment', () => { | |||
mattseddon
force-pushed
the
prevent-selection-of-running
branch
from
448afda to
ca4c711
Compare
sroy3
approved these changes
Apr 19, 2023
This was referenced Apr 20, 2023
mattseddon
added a commit
that referenced
this pull request
Apr 20, 2023
…outside the workspace) (#3665) * wrap all loose test data in test data generator * add new type * duplicate required functions but use new data * update test fixtures * deduplicate functions * remove checkpoints model and file system watcher (#3684) * extend timeout of run experiment test (e2e) (#3713) * prevent plotting of running experiments (#3712) * trigger plot updates whenever commit data changes (#3715) * update demo project and min required version of DVC * fix experiment id for commits (shown in plots) (#3724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #3665 <- thisReplaces #3705
This PR ensures that queued/running experiments cannot be selected for plotting. In the special case that an experiment is running in the workspace and the user tries to select that experiment for plotting the workspace will be selected.