Use exp push to share experiments to Studio #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
commented
Apr 18, 2023
mattseddon
commented
Apr 18, 2023
| @@ -115,10 +115,22 @@ export const getShareExperimentToStudioCommand = | |||
| return commands.executeCommand(RegisteredCommands.SETUP_SHOW) | |||
| } | |||
|
|
|||
| return internalCommands.executeCommand( | |||
| AvailableCommands.EXP_PUSH, | |||
There was a problem hiding this comment.
[I] Make sure to remove this from internal commands too (it is in the types).
mattseddon
force-pushed
the
remove-push-patch
branch
from
4873421 to
386e939
Compare
mattseddon
force-pushed
the
remove-push-patch
branch
from
386e939 to
491d0d8
Compare
mattseddon
force-pushed
the
remove-push-patch
branch
from
491d0d8 to
152913e
Compare
mattseddon
force-pushed
the
remove-push-patch
branch
from
86a4dba to
9e40b4d
Compare
This was referenced Apr 27, 2023
sroy3
approved these changes
Apr 27, 2023
This was referenced Apr 28, 2023
mattseddon
force-pushed
the
remove-push-patch
branch
from
9e40b4d to
f247d04
Compare
|
Code Climate has analyzed commit f247d04 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/6
main<- #3768 <- this <- #3771 <- #3777 <- #3778 <- #3779Related to #3574.
This is an interim step where we move "Share to Studio" from our custom implementation of the studio client onto exp push. I'll remove the other 2 sharing actions shortly and rename "Share to Studio" to "Share". I'll also make it possible to share without a Studio token, under those circumstances, I will prompt the user to add a token.
Demo
Screen.Recording.2023-04-27.at.3.37.56.pm.mov