Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIT_TERMINAL_PROMPT=0 to DVC environment variables #3779

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Apr 28, 2023

6/6 main <- #3768 <- #3701 <- #3771 <- #3777 <- #3778 <- this

Follow up to iterative/dvc#9339.

This PR adds GIT_TERMINAL_PROMPT: '0' to the environment variables when calling DVC. This will stop the process from hanging whilst waiting for the user to enter credentials. For more details read the above issue 🙏🏻.

Git docs are here.

Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the rename-exp-commands branch from 92c5714 to 4ca4b37 Compare April 28, 2023 22:37
Base automatically changed from rename-exp-commands to main April 28, 2023 22:47
@mattseddon mattseddon enabled auto-merge (squash) April 29, 2023 00:21
@codeclimate
Copy link

codeclimate bot commented Apr 29, 2023

Code Climate has analyzed commit 213a1a9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.1% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 496d2d7 into main Apr 29, 2023
@mattseddon mattseddon deleted the fail-on-git-prompt branch April 29, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants