self review

iterative · Apr 28, 2023 · f247d04 · f247d04
1 parent 3dfb522
commit f247d04
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/extension/src/commands/internal.ts b/extension/src/commands/internal.ts
@@ -18,7 +18,7 @@ import { Disposable } from '../class/dispose'
 type Command = (...args: Args) => unknown | Promise<unknown>
 
 export const AvailableCommands = Object.assign(
-  { EXP_PUSH: 'expPush' } as const,
+  {},
   DvcExecutorCommands,
   DvcReaderCommands,
   DvcRunnerCommands,
@@ -30,7 +30,7 @@ export const AvailableCommands = Object.assign(
   typeof DvcRunnerCommands &
   typeof DvcViewerCommands &
   typeof GitExecutorCommands &
-  typeof GitReaderCommands & { EXP_PUSH: 'expPush' }
+  typeof GitReaderCommands
 export type CommandId =
   (typeof AvailableCommands)[keyof typeof AvailableCommands]
 

diff --git a/extension/src/experiments/commands/index.ts b/extension/src/experiments/commands/index.ts
@@ -115,10 +115,10 @@ export const getShareExperimentToStudioCommand =
       return commands.executeCommand(RegisteredCommands.SETUP_SHOW)
     }
 
-    return Toast.showProgress('Pushing Experiment', async progress => {
+    return Toast.showProgress('Sharing', async progress => {
       progress.report({ increment: 0 })
 
-      progress.report({ increment: 25, message: 'Pushing experiment...' })
+      progress.report({ increment: 25, message: 'Running exp push...' })
 
       await Toast.runCommandAndIncrementProgress(
         () =>
@@ -131,6 +131,6 @@ export const getShareExperimentToStudioCommand =
         75
       )
 
-      return Toast.delayProgressClosing()
+      return Toast.delayProgressClosing(15000)
     })
   }
diff --git a/extension/src/vscode/toast.ts b/extension/src/vscode/toast.ts
@@ -75,8 +75,8 @@ export class Toast {
     })
   }
 
-  static delayProgressClosing() {
-    return delay(5000)
+  static delayProgressClosing(ms = 5000) {
+    return delay(ms)
   }
 
   private static waitForResponse(