Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable popover component for annotation editors #4139

Closed
3 tasks done
reckart opened this issue Aug 3, 2023 · 0 comments
Closed
3 tasks done

Reusable popover component for annotation editors #4139

reckart opened this issue Aug 3, 2023 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: JavaScript Editor API
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Aug 3, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, only the brat editor has an info popover... and it is not really reusable.

Describe the solution you'd like
Implement a reusable component that can be used by multiple editors.

  • Popover is there and can be reused
  • Popover disappears after a while if user switches to other window and then move mouse back again into INCEpTION window
  • Sentence-level popup in brat editor uses new widget
@reckart reckart added this to the 30.0 milestone Aug 3, 2023
@reckart reckart self-assigned this Aug 3, 2023
reckart added a commit that referenced this issue Aug 10, 2023
@reckart
Issue #4139: Reusable popover component for annotation editors
15fb450 
- Basic Svelte component for info popover
- Use this component in the Apache Annotator editor
reckart added a commit that referenced this issue Aug 10, 2023
@reckart
Issue #4139: Reusable popover component for annotation editors
a693e7f 
- Introduce lazy detail groups
- Add lazy-detail support to the re-usable popover component
reckart added a commit that referenced this issue Aug 10, 2023
@reckart
#4139 - Reusable popover component for annotation editors
813239e 
- Implemented reusable popup
- Use it in the Apache Annotator editor and the annotation sidebar
reckart added a commit that referenced this issue Aug 11, 2023
@reckart
#4139 - Reusable popover component for annotation editors
a7a3090 
- Implemented reusable popup
- Use it in the Apache Annotator editor and the annotation sidebar
reckart added a commit that referenced this issue Aug 11, 2023
@reckart
#4139 - Reusable popover component for annotation editors
86925df 
- Add the popover to the PDF editor
reckart added a commit that referenced this issue Aug 11, 2023
@reckart
#4139 - Reusable popover component for annotation editors
b235da2 
- Add the popover to the PDF editor
reckart added a commit that referenced this issue Aug 11, 2023
@reckart
#4139 - Reusable popover component for annotation editors
1a29ee3 
- Add the popover to the PDF editor
reckart added a commit that referenced this issue Aug 12, 2023
@reckart
#4139 - Reusable popover component for annotation editors
71a8a30 
- Raise target JS level to es2018
- Add new popover to the brat editor
- Remove rests of old lazy details code from brat editor
- esbuild 0.16.17 -> 0.18.19
- esbuild-sass-plugin 2.5.0 -> 2.10.0
- esbuild-svelte 0.7.3 -> 0.7.4
- mocha 10.0.0 -> 10.2.0
- mocha-junit-reporter 2.1.0 -> 2.2.1
- popperjs 2.11.7 -> 2.11.8
- svelte 3.55.0 -> 3.59.2
- svelte-preprocess 5.0.0 -> 5.0.4
- ts-mocha -> 10.0.0
- types-mocha 9.1.1 -> 10.0.1
- Regenerate package.json files
reckart added a commit that referenced this issue Aug 12, 2023
@reckart
Merge pull request #4146 from inception-project/feature/4139-Reusable…
37e55f0 
…-popover-component-for-annotation-editors

#4139 - Reusable popover component for annotation editors
reckart added a commit that referenced this issue Aug 21, 2023
@reckart
#4139 - Reusable popover component for annotation editors
059e7df 
- Remove "Yield" as a separate comment type - it is just a regular info comment
reckart added a commit that referenced this issue Aug 21, 2023
@reckart
Merge pull request #4152 from inception-project/feature/4139-Reusable…
4bc20e6 
…-popover-component-for-annotation-editors

#4139 - Reusable popover component for annotation editors
@reckart reckart closed this as completed Aug 22, 2023
@reckart reckart mentioned this issue Aug 22, 2023
Closed
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into bugfix/4158-Exception-when-annotating-someth…
3584db3 
…ing-after-a-longer-pause

* main:
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT

% Conflicts:
%	Jenkinsfile
%	inception/inception-active-learning/src/main/java/de/tudarmstadt/ukp/inception/active/learning/sidebar/ActiveLearningSidebar.java
%	inception/inception-brat-editor/src/main/ts/src/annotator_ui/ResizeManager.ts
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
b459a34 
* main: (94 commits)
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.0
  #3673 - Update dependencies
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT
  ...

% Conflicts:
%	inception/inception-diam/pom.xml
%	inception/inception-docker/src/main/docker/Dockerfile
%	inception/inception-io-xmi/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-project-export/src/test/java/de/tudarmstadt/ukp/inception/project/export/controller/ExportServiceControllerImplTest.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-remote/pom.xml
%	inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/page/ApplicationPageBase.java
%	inception/pom.xml
@reckart reckart reopened this Oct 23, 2023
reckart added a commit that referenced this issue Oct 23, 2023
@reckart
#4139 - Reusable popover component for annotation editors
b06b648 
- Send sentence VID to brat
- Use the new popover also for the sentence IDs in the brat editor
- Clean up listeners in popover component
- Add loading indicator to popover component
reckart added a commit that referenced this issue Oct 23, 2023
@reckart
#4139 - Reusable popover component for annotation editors
474871c 
- Send sentence VID to brat
- Use the new popover also for the sentence IDs in the brat editor
- Clean up listeners in popover component
- Add loading indicator to popover component
reckart added a commit that referenced this issue Oct 24, 2023
@reckart
#4139 - Reusable popover component for annotation editors
7249147 
- Send sentence VID to brat
- Use the new popover also for the sentence IDs in the brat editor
- Clean up listeners in popover component
- Add loading indicator to popover component
reckart added a commit that referenced this issue Oct 24, 2023
@reckart
Merge pull request #4254 from inception-project/feature/4139-Reusable…
d80b312 
…-popover-component-for-annotation-editors

#4139 - Reusable popover component for annotation editors
@reckart reckart closed this as completed Oct 24, 2023
reckart added a commit that referenced this issue Nov 3, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
9022f4d 
* main: (26 commits)
  #4258 - Reset document button for annotators in dynamic assignment mode
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.8
  #4266 - Improve backToProject call
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.7
  No issue: Handle edge case
  #4263 - Spans starting before the current viewport are not rendered as partial spans
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.6
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4259 - Opening a document viewing a specific annotator from the activities list does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4256 - Avoid saving preferences immediately on load
  #4139 - Reusable popover component for annotation editors
  #4252 - Limit number of annotations displayed in annotation sidebar to avoid crash
  #4251 - Improve speed of yield calculation
  ...

% Conflicts:
%	inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionSecurityWebUIShared.java
%	inception/inception-documents/src/main/java/de/tudarmstadt/ukp/inception/documents/DocumentAccessImpl.java
%	inception/inception-ui-dashboard-activity/src/main/java/de/tudarmstadt/ukp/inception/ui/core/dashboard/activity/ActivitiesDashletControllerImpl.java
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/annotation/DynamicAnnotatorWorkflowActionBarItemGroup.java
@reckart reckart mentioned this issue Nov 7, 2023
Closed
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: JavaScript Editor API
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart