Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backToProject call #4266

Closed
reckart opened this issue Nov 1, 2023 · 0 comments
Closed

Improve backToProject call #4266

reckart opened this issue Nov 1, 2023 · 0 comments
Assignees
Milestone

Comments

@reckart
Copy link
Member

reckart commented Nov 1, 2023

Describe the refactoring action
backToProject() should direct away from the current page in all cases.

Expected benefit
Meet the expectation that caller code has when invoking backToProject().

@reckart reckart added this to the 29.8 milestone Nov 1, 2023
@reckart reckart self-assigned this Nov 1, 2023
reckart added a commit that referenced this issue Nov 1, 2023
- Redirect to dashboard if possible and to dead-end page if not possible
reckart added a commit that referenced this issue Nov 1, 2023
- Redirect to dashboard if possible and to dead-end page if not possible
reckart added a commit that referenced this issue Nov 1, 2023
- Redirect to dashboard if possible and to dead-end page if not possible
reckart added a commit that referenced this issue Nov 2, 2023
…ove-backToProject-call

#4266 - Improve backToProject call
@reckart reckart closed this as completed Nov 2, 2023
reckart added a commit that referenced this issue Nov 2, 2023
* release/29.x:
  #4266 - Improve backToProject call
reckart added a commit that referenced this issue Nov 2, 2023
…ators-in-dynamic-assignment-mode

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.8
  #4266 - Improve backToProject call
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.7
  No issue: Handle edge case
  #4263 - Spans starting before the current viewport are not rendered as partial spans
reckart added a commit that referenced this issue Nov 3, 2023
* main: (26 commits)
  #4258 - Reset document button for annotators in dynamic assignment mode
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.8
  #4266 - Improve backToProject call
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.7
  No issue: Handle edge case
  #4263 - Spans starting before the current viewport are not rendered as partial spans
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.6
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4259 - Opening a document viewing a specific annotator from the activities list does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4256 - Avoid saving preferences immediately on load
  #4139 - Reusable popover component for annotation editors
  #4252 - Limit number of annotations displayed in annotation sidebar to avoid crash
  #4251 - Improve speed of yield calculation
  ...

% Conflicts:
%	inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionSecurityWebUIShared.java
%	inception/inception-documents/src/main/java/de/tudarmstadt/ukp/inception/documents/DocumentAccessImpl.java
%	inception/inception-ui-dashboard-activity/src/main/java/de/tudarmstadt/ukp/inception/ui/core/dashboard/activity/ActivitiesDashletControllerImpl.java
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/annotation/DynamicAnnotatorWorkflowActionBarItemGroup.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant