Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct access-by-URL to sidebar curation mode sometimes does not work #4235

Closed
reckart opened this issue Oct 9, 2023 · 0 comments
Closed

Direct access-by-URL to sidebar curation mode sometimes does not work #4235

reckart opened this issue Oct 9, 2023 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation Module: Curation
Milestone
29.6

Comments

@reckart
Copy link
Member

reckart commented Oct 9, 2023

Describe the bug
Direct access-by-URL to sidebar curation mode sometimes does not work. Different types of errors can occur including a blank screen or an error about concurrent access.

Expected behavior
Enabling/disabling sidebar curation mode via URL parameters should work in all situations.

Please complete the following information:

  • Version and build ID: 29.4
@reckart reckart added this to the 29.5 milestone Oct 9, 2023
@reckart reckart self-assigned this Oct 9, 2023
reckart added a commit that referenced this issue Oct 9, 2023
@reckart
#4235 - Direct access-by-URL to sidebar curation mode sometimes does …
d823fbf 
…not work

- Use alternative approach to react to the URL parameters
reckart added a commit that referenced this issue Oct 9, 2023
@reckart
Merge pull request #4236 from inception-project/bugfix/4235-Direct-ac…
c6aa0a5 
…cess-by-URL-to-sidebar-curation-mode-sometimes-does-not-work

#4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
@reckart reckart closed this as completed Oct 9, 2023
reckart added a commit that referenced this issue Oct 9, 2023
@reckart
Merge branch 'release/29.x'
77a51a8 
* release/29.x:
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
reckart added a commit that referenced this issue Oct 10, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
fbf4546 
* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4229 - Better project template selection

% Conflicts:
%	pom.xml
reckart added a commit that referenced this issue Oct 10, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
f9fcbea 
* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4229 - Better project template selection

% Conflicts:
%	pom.xml
@reckart reckart reopened this Oct 12, 2023
@reckart reckart modified the milestones: 29.5, 29.6 Oct 12, 2023
reckart added a commit that referenced this issue Oct 12, 2023
@reckart
#4235 - Direct access-by-URL to sidebar curation mode sometimes does …
5bfd9de 
…not work

- Introduce a new event "PreparingToOpenDocumentEvent" which gives the curation sidebar the opportunity to set the data owner to the curation target before actually starting to load the document.
- Improve debug/trace logging
- Modernizing some terminologies and use var
reckart added a commit that referenced this issue Oct 14, 2023
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
527ac03 
* main: (94 commits)
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4232 - Drop evaluation page
  #4229 - Better project template selection
  #4230 - Upgrade dependencies
  #4229 - Better project template selection
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  ...

% Conflicts:
%	inception/inception-imls-external/pom.xml
reckart added a commit that referenced this issue Oct 14, 2023
@reckart
Merge branch 'main' into feature/3411-Resize-sidebars-using-mouse
b403030 
* main: (211 commits)
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4232 - Drop evaluation page
  #4229 - Better project template selection
  #4230 - Upgrade dependencies
  #4229 - Better project template selection
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  ...

% Conflicts:
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/sidebar/SidebarTabbedPanel.java
reckart added a commit that referenced this issue Oct 26, 2023
@reckart
#4235 - Direct access-by-URL to sidebar curation mode sometimes does …
e6b7825 
…not work

- More detailed trace logging related to curation sidebar and access control
reckart added a commit that referenced this issue Oct 29, 2023
@reckart
#4235 - Direct access-by-URL to sidebar curation mode sometimes does …
2f097ec 
…not work

- Move initialization of CurationSidebarBehaviour into a proper application initializer
- Improve pushing of page paraemeters into fragement parameters in AnnotationPageBase
reckart added a commit that referenced this issue Oct 31, 2023
@reckart
Merge pull request #4242 from inception-project/bugfix/4235-Direct-ac…
a71ae8e 
…cess-by-URL-to-sidebar-curation-mode-sometimes-does-not-work

#4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
@reckart reckart closed this as completed Oct 31, 2023
reckart added a commit that referenced this issue Oct 31, 2023
@reckart
Merge branch 'release/29.x'
1990c16 
* release/29.x:
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
reckart added a commit that referenced this issue Oct 31, 2023
@reckart
Merge branch 'main' into feature/4258-Reset-document-button-for-annot…
02ded07 
…ators-in-dynamic-assignment-mode

* main:
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
reckart added a commit that referenced this issue Nov 3, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
9022f4d 
* main: (26 commits)
  #4258 - Reset document button for annotators in dynamic assignment mode
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.8
  #4266 - Improve backToProject call
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.7
  No issue: Handle edge case
  #4263 - Spans starting before the current viewport are not rendered as partial spans
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.6
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4258 - Reset document button for annotators in dynamic assignment mode
  #4259 - Opening a document viewing a specific annotator from the activities list does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4256 - Avoid saving preferences immediately on load
  #4139 - Reusable popover component for annotation editors
  #4252 - Limit number of annotations displayed in annotation sidebar to avoid crash
  #4251 - Improve speed of yield calculation
  ...

% Conflicts:
%	inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionSecurityWebUIShared.java
%	inception/inception-documents/src/main/java/de/tudarmstadt/ukp/inception/documents/DocumentAccessImpl.java
%	inception/inception-ui-dashboard-activity/src/main/java/de/tudarmstadt/ukp/inception/ui/core/dashboard/activity/ActivitiesDashletControllerImpl.java
%	inception/inception-workload-dynamic/src/main/java/de/tudarmstadt/ukp/inception/workload/dynamic/annotation/DynamicAnnotatorWorkflowActionBarItemGroup.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation Module: Curation
Projects
Kanban
Archived in project
Milestone
29.6
Development

No branches or pull requests
1 participant
@reckart