Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display logout button on annotation page if dashboard access is disabled #4226

Closed
reckart opened this issue Oct 3, 2023 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@reckart
Copy link
Member

reckart commented Oct 3, 2023

Is your feature request related to a problem? Please describe.
When dashboard access is disabled, actually the entire top menu bar disappears including the logout button.

Describe the solution you'd like
Integrate a logout button into the annotation action bar if dashboard access is disabled.

@reckart reckart added this to the 29.4 milestone Oct 3, 2023
@reckart reckart self-assigned this Oct 3, 2023
reckart added a commit that referenced this issue Oct 3, 2023
…is disabled

- Added logout button to the annotation action bar if the menu bar is not accessible
- If menubar is accessible, the logout button should always be there
- If logging out while auto-login is enabled, make sure to pass the skip-auto-login parameter to the login page
- Allow items in the annotation action bar to grow which allows the logout button to be positioned at the far right
- Improve scaling of the annotation action bar when window is resized
reckart added a commit that referenced this issue Oct 3, 2023
…logout-button-on-annotation-page-if-dashboard-access-is-disabled

#4226 - Display logout button on annotation page if dashboard access is disabled
@reckart reckart closed this as completed Oct 3, 2023
reckart added a commit that referenced this issue Oct 3, 2023
* release/29.x:
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  #4226 - Display logout button on annotation page if dashboard access is disabled
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
reckart added a commit that referenced this issue Oct 3, 2023
reckart added a commit that referenced this issue Oct 3, 2023
* release/29.x:
  #4226 - Display logout button on annotation page if dashboard access is disabled
reckart added a commit that referenced this issue Oct 8, 2023
* main:
  #4232 - Drop evaluation page
  #4230 - Upgrade dependencies
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  #4226 - Display logout button on annotation page if dashboard access is disabled
  #4150 - Upgrade dependencies
  #4223 - Covered text should show in popover
  #4215 - Ability to specify GID and UID for the user used inside the Docker image

% Conflicts:
%	inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/logout/LogoutPanel.java
reckart added a commit that referenced this issue Oct 14, 2023
* main: (94 commits)
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4232 - Drop evaluation page
  #4229 - Better project template selection
  #4230 - Upgrade dependencies
  #4229 - Better project template selection
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  ...

% Conflicts:
%	inception/inception-imls-external/pom.xml
reckart added a commit that referenced this issue Oct 14, 2023
* main: (211 commits)
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4232 - Drop evaluation page
  #4229 - Better project template selection
  #4230 - Upgrade dependencies
  #4229 - Better project template selection
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  ...

% Conflicts:
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/sidebar/SidebarTabbedPanel.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant