Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4139 - Reusable popover component for annotation editors #4146

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 10, 2023

What's in the PR

  • Implemented reusable popup
  • Use it in the Apache Annotator editor and the annotation sidebar
  • Use it in the PDF editor
  • Use it in the brat editor
  • Use it in the annotation sidebar

How to test manually

  • Try the Apache Annotator editor and/or the annotation sidebar - hover with the mouse over an annotation

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

reckart added 4 commits August 3, 2023 22:34
- Basic Svelte component for info popover
- Use this component in the Apache Annotator editor
…annotation-editors

* main:
  #4140 - Simplify lazy detail lookup

% Conflicts:
%	inception/inception-api-schema/src/main/java/de/tudarmstadt/ukp/inception/rendering/Renderer.java
- Introduce lazy detail groups
- Add lazy-detail support to the re-usable popover component
…annotation-editors

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.0
  #3673 - Update dependencies
@reckart reckart added this to the 30.0 milestone Aug 10, 2023
@reckart reckart self-assigned this Aug 10, 2023
- Implemented reusable popup
- Use it in the Apache Annotator editor and the annotation sidebar
@reckart reckart force-pushed the feature/4139-Reusable-popover-component-for-annotation-editors branch from 813239e to a7a3090 Compare August 11, 2023 17:58
…annotation-editors

* main:
  Issue #4148: Switch PDF editor to compact model v2
@reckart reckart force-pushed the feature/4139-Reusable-popover-component-for-annotation-editors branch from 86925df to b235da2 Compare August 11, 2023 20:05
- Add the popover to the PDF editor
@reckart reckart force-pushed the feature/4139-Reusable-popover-component-for-annotation-editors branch from b235da2 to 1a29ee3 Compare August 11, 2023 20:52
- Raise target JS level to es2018
- Add new popover to the brat editor
- Remove rests of old lazy details code from brat editor
- esbuild 0.16.17 -> 0.18.19
- esbuild-sass-plugin 2.5.0 -> 2.10.0
- esbuild-svelte 0.7.3 -> 0.7.4
- mocha 10.0.0 -> 10.2.0
- mocha-junit-reporter 2.1.0 -> 2.2.1
- popperjs 2.11.7 -> 2.11.8
- svelte 3.55.0 -> 3.59.2
- svelte-preprocess 5.0.0 -> 5.0.4
- ts-mocha -> 10.0.0
- types-mocha 9.1.1 -> 10.0.1
- Regenerate package.json files
@reckart reckart merged commit 37e55f0 into main Aug 12, 2023
@reckart reckart deleted the feature/4139-Reusable-popover-component-for-annotation-editors branch August 12, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant