Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify lazy detail lookup #4140

Closed
reckart opened this issue Aug 5, 2023 · 0 comments
Closed

Simplify lazy detail lookup #4140

reckart opened this issue Aug 5, 2023 · 0 comments
Assignees
@reckart
Labels
Module: Annotation Module: JavaScript Editor API
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Aug 5, 2023

Describe the refactoring action
The current lazy details sends a set of queries along with the rendered data. Those queries is then sent back to the server when the user hovers over an annotation. Finally, the result to the queries are rendered in the popover.

It is unnecessary to send the query as part of rendering. It would be sufficient for the server to get a request for lazy details for a given annotation when the user hovers over it and then the server could immediately respond with all the details.

Expected benefit
Smaller render size, less code to maintain.
@reckart reckart added this to the 30.0 milestone Aug 5, 2023
@reckart reckart self-assigned this Aug 5, 2023
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
042ea5f 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
94deb69 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
9943ded 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
d78e812 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
424b451 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
#4140 - Simplify lazy detail lookup
b0750e7 
- Remove getLazyDetails() methods that produced the queries
- Remove all classes related to the queries
- Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart added a commit that referenced this issue Aug 5, 2023
@reckart
Merge pull request #4141 from inception-project/refactoring/4140-Simp…
10c2d69 
…lify-lazy-detail-lookup

#4140 - Simplify lazy detail lookup
@reckart reckart closed this as completed Aug 5, 2023
reckart added a commit that referenced this issue Aug 10, 2023
@reckart
Merge branch 'main' into feature/4139-Reusable-popover-component-for-…
97eb5a6 
…annotation-editors

* main:
  #4140 - Simplify lazy detail lookup

% Conflicts:
%	inception/inception-api-schema/src/main/java/de/tudarmstadt/ukp/inception/rendering/Renderer.java
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into bugfix/4158-Exception-when-annotating-someth…
3584db3 
…ing-after-a-longer-pause

* main:
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT

% Conflicts:
%	Jenkinsfile
%	inception/inception-active-learning/src/main/java/de/tudarmstadt/ukp/inception/active/learning/sidebar/ActiveLearningSidebar.java
%	inception/inception-brat-editor/src/main/ts/src/annotator_ui/ResizeManager.ts
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
b459a34 
* main: (94 commits)
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.0
  #3673 - Update dependencies
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT
  ...

% Conflicts:
%	inception/inception-diam/pom.xml
%	inception/inception-docker/src/main/docker/Dockerfile
%	inception/inception-io-xmi/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-project-export/src/test/java/de/tudarmstadt/ukp/inception/project/export/controller/ExportServiceControllerImplTest.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-remote/pom.xml
%	inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/page/ApplicationPageBase.java
%	inception/pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: Annotation Module: JavaScript Editor API
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart