#4140 - Simplify lazy detail lookup #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckart
force-pushed
the
refactoring/4140-Simplify-lazy-detail-lookup
branch
4 times, most recently
from
d78e812 to
424b451
Compare
- Remove getLazyDetails() methods that produced the queries - Remove all classes related to the queries - Make lookupLazyDetails produce all the details on the fly when asked for details for a given VID
reckart
force-pushed
the
refactoring/4140-Simplify-lazy-detail-lookup
branch
from
424b451 to
b0750e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation