Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add viewport offsets to external recommender #1861

Open
1 of 3 tasks
jcklie opened this issue Nov 24, 2020 · 0 comments
Open
1 of 3 tasks

Add viewport offsets to external recommender #1861

jcklie opened this issue Nov 24, 2020 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: Recommender
Milestone
⭐️ Feature backlog

Comments

@jcklie
Copy link
Contributor

jcklie commented Nov 24, 2020 •
edited by reckart
Loading

Is your feature request related to a problem? Please describe.
Add viewport offsets to external recommender so that the recommender knows where to predict.

Describe the solution you'd like
Add viewport begin/end to external recommender request.

Todo

  • Send viewport along
  • Allow external recommender to respond the area in which it actually did predict or handle this on the INCEpTION side
  • Report the predicted range to the recommender service
@jcklie jcklie added this to the 0.18.0 milestone Nov 24, 2020
@jcklie jcklie self-assigned this Nov 24, 2020
@reckart reckart modified the milestones: 0.18.0, Feature backlog Jan 13, 2021
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1861 from webanno/bugfix/1860-redirect-after-login
9a71cb8 
#1860 Redirect to previous url after login does not work
@reckart reckart modified the milestones: ⭐️ Feature backlog, 24.0 Apr 12, 2022
@reckart reckart modified the milestones: 24.0, 25.0 Jun 20, 2022
@reckart reckart modified the milestones: 25.0, 26.0 Sep 30, 2022
@reckart reckart modified the milestones: 26.0, 27.0 Nov 5, 2022
@reckart reckart modified the milestones: 27.0, 28.0 Jan 4, 2023
@reckart reckart modified the milestones: 28.0, 29.0 May 2, 2023
@reckart reckart modified the milestones: 29.0, 30.0 Jul 29, 2023
reckart added a commit that referenced this issue Aug 22, 2023
@reckart
#1861 - Add viewport offsets to external recommender
9047b78 
- Send viewport offsets to external recommender
- Bit of cleaning up
reckart added a commit that referenced this issue Aug 23, 2023
@reckart
#1861 - Add viewport offsets to external recommender
941fc6a 
- Send viewport offsets to external recommender
- Bit of cleaning up
reckart added a commit that referenced this issue Aug 25, 2023
@reckart
Merge pull request #4154 from inception-project/feature/1861-Add-view…
372724a 
…port-offsets-to-external-recommender

#1861 - Add viewport offsets to external recommender
reckart added a commit that referenced this issue Aug 25, 2023
@reckart
#1861 - Add viewport offsets to external recommender
5b3a70b 
- Configure build to run on Java 17
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into bugfix/4158-Exception-when-annotating-someth…
3584db3 
…ing-after-a-longer-pause

* main:
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT

% Conflicts:
%	Jenkinsfile
%	inception/inception-active-learning/src/main/java/de/tudarmstadt/ukp/inception/active/learning/sidebar/ActiveLearningSidebar.java
%	inception/inception-brat-editor/src/main/ts/src/annotator_ui/ResizeManager.ts
reckart added a commit that referenced this issue Sep 2, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
b459a34 
* main: (94 commits)
  #4150 - Upgrade dependencies
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4150 - Upgrade dependencies
  #4150 - Upgrade dependencies
  #1861 - Add viewport offsets to external recommender
  #4155 - Better annotation suggestion IDs
  #4155 - Better annotation suggestion IDs
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  #4139 - Reusable popover component for annotation editors
  Issue #4148: Switch PDF editor to compact model v2
  #4139 - Reusable popover component for annotation editors
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.0
  #3673 - Update dependencies
  Issue #4139: Reusable popover component for annotation editors
  #4140 - Simplify lazy detail lookup
  Issue #4139: Reusable popover component for annotation editors
  No issue. Set version to 30.0-SNAPSHOT
  ...

% Conflicts:
%	inception/inception-diam/pom.xml
%	inception/inception-docker/src/main/docker/Dockerfile
%	inception/inception-io-xmi/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
%	inception/inception-project-export/src/test/java/de/tudarmstadt/ukp/inception/project/export/controller/ExportServiceControllerImplTest.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventWebsocketControllerImplTest.java
%	inception/inception-remote/pom.xml
%	inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/page/ApplicationPageBase.java
%	inception/pom.xml
@reckart reckart modified the milestones: 30.0, 31.0 Sep 19, 2023
@reckart reckart modified the milestones: 31.0, 32.0 Jan 6, 2024
@reckart reckart assigned reckart and unassigned jcklie Apr 5, 2024
@reckart reckart modified the milestones: 32.0, 33.0 Apr 5, 2024
@reckart reckart modified the milestones: 33.0, 34.0 Jun 2, 2024
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🔖 To do in Kanban Aug 7, 2024
@reckart reckart modified the milestones: 34.0, 35.0 Sep 1, 2024
@reckart reckart modified the milestones: 35.0, ⭐️ Feature backlog Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
Status: 🔖 To do
Milestone
⭐️ Feature backlog
Development

No branches or pull requests
2 participants
@jcklie @reckart