Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4139 - Reusable popover component for annotation editors #4254

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 23, 2023

What's in the PR

  • Send sentence VID to brat
  • Use the new popover also for the sentence IDs in the brat editor
  • Clean up listeners in popover component
  • Add loading indicator to popover component

How to test manually

  • Import a document with sentence IDs
  • View it in brat mode
  • Hover with the mouse over a sentence number to see the ID

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 30.0 milestone Oct 23, 2023
@reckart reckart self-assigned this Oct 23, 2023
@reckart reckart force-pushed the feature/4139-Reusable-popover-component-for-annotation-editors branch from b06b648 to 474871c Compare October 23, 2023 20:50
- Send sentence VID to brat
- Use the new popover also for the sentence IDs in the brat editor
- Clean up listeners in popover component
- Add loading indicator to popover component
@reckart reckart force-pushed the feature/4139-Reusable-popover-component-for-annotation-editors branch from 474871c to 7249147 Compare October 24, 2023 07:28
@reckart reckart merged commit d80b312 into main Oct 24, 2023
@reckart reckart deleted the feature/4139-Reusable-popover-component-for-annotation-editors branch October 24, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant