Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.0.4 #1067

Closed
wants to merge 29 commits into from
Closed

Release v1.0.4 #1067

wants to merge 29 commits into from

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Jun 17, 2022 •
edited
Loading

TL;DR

Preparing a subset of changes in master to release as a patch release

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

List of changes pulled in:

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

wild-endeavor and others added 28 commits June 17, 2022 11:16
@wild-endeavor @eapolinario
FlyteRemote data context does not get used (#993)
4982484 
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor @eapolinario
Add default list transformer for legacy config (#998)
8c94362 
Signed-off-by: Yee Hing Tong <[email protected]>
@kumare3 @eapolinario
pyflyte run can now execute a task either locally or remote (#995)
58aca28 
* pyflyte run can now execute a task either locally or remote

Signed-off-by: Ketan Umare <[email protected]>

* Fix namedtuple and test

Signed-off-by: Ketan Umare <[email protected]>
@wild-endeavor @eapolinario
Allow users to just have one --pkgs switch, but have commas in there …
a961336 
…indicating separate packages (#999)

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor @eapolinario
Bump plugin pins to 1.1-> 1.2 (#1001)
9de00b4 
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor @eapolinario
Read packages from environment variables (#1002)
5bc9438 
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor @eapolinario
pip compile papermill and fsspec plugins (#1003)
72e9e87 
Signed-off-by: Yee Hing Tong <[email protected]>
@cosmicBboy @eapolinario
pass fileaccess data config to data persistence plugin (#1004)
429ed21 
Signed-off-by: Niels Bantilan <[email protected]>
@stef-stripe @eapolinario
Correctly resolve forwardrefs in namedtuple typing (#1005)
66916a9 
Signed-off-by: Yee Hing Tong <[email protected]>
@EngHabu @snyk-bot @eapolinario
fix: doc-requirements.txt to reduce vulnerabilities (#1012)
4e47ecf 
The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-PILLOW-2838873

Co-authored-by: snyk-bot <[email protected]>
@vvasavada-fn @eapolinario
Update get_serializable_workflow to consistently generate the same su…
86cc590 
…bworkflow order (#1011)

* update get_serializable_workflow

Signed-off-by: Vrinda Vasavada <[email protected]>

* make fmt

Signed-off-by: Vrinda Vasavada <[email protected]>
@pingsutw @eapolinario
Fix the tests on windows (#1013)
64b9c31 
* Fix the tests on windows

Signed-off-by: Kevin Su <[email protected]>

* Fix the tests on windows

Signed-off-by: Kevin Su <[email protected]>

* Add comment

Signed-off-by: Kevin Su <[email protected]>

* Fix tests

Signed-off-by: Kevin Su <[email protected]>

* pin pip

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>
@wild-endeavor @eapolinario
Skip config checking if no ini config file present (#1016)
682dbcb 
Signed-off-by: Yee Hing Tong <[email protected]>
@eapolinario
Bump requirements 1653070910 (#1014)
a5fe4be 
* Bump requirements files to bring in ipython>7.31

Signed-off-by: Eduardo Apolinario <[email protected]>

* Bump plugins requirements

Signed-off-by: Eduardo Apolinario <[email protected]>

* delete flytekit-deck-standard/__init__.py

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix importing code in script mode (#1021)
95c33c9 
* Fix importing code in script mode

* Store _filename using an absolute path and comment the use of it

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@wild-endeavor @eapolinario
Use interface instead of python_interface to support remote entities …
4c63b44 
…in imperative (#1000)


Signed-off-by: Yee Hing Tong <[email protected]>
@RobertoRRW @eapolinario
Added support for insecureSkipVerify on pyflyte (#1020)
32e311b 
* Added support for insecureSkipVerify

Signed-off-by: Roberto Ruiz <[email protected]>

* Extract port from endpoint before obtaining unverified SSL certificate

Signed-off-by: Roberto Ruiz <[email protected]>

* Code reformat using black

Signed-off-by: Roberto Ruiz <[email protected]>

* Added pyopenssl requirement

Signed-off-by: Roberto Ruiz <[email protected]>

* Corrected error from typo

Signed-off-by: Roberto Ruiz <[email protected]>

* Added corrections on how the endpoint is split into server and port

Signed-off-by: Roberto Ruiz <[email protected]>

* Use the correct split method to handle multiple occurrences of ':'

Signed-off-by: Roberto Ruiz <[email protected]>

* Regenerated requirements-spark2.txt and doc-requirements.txt

Signed-off-by: Roberto Ruiz <[email protected]>

* Generated all requirements files together

Signed-off-by: Roberto Ruiz <[email protected]>
@RobertoRRW @eapolinario
Allow struct/dataclass types to be used as default arguments (#1024)
23360e6 
* Allow struct/dataclass types to be used as default arguments

Signed-off-by: Roberto Ruiz <[email protected]>

* Add test case

Signed-off-by: Eduardo Apolinario <[email protected]>

* Lint

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@samhita-alla @eapolinario
capture default list/dict inputs in Usage: pyflyte run [OPTIONS] COMM…
d94c0f1 
…AND [ARGS]... (#1033)

This command can execute either a workflow or a task from the commandline,
  for fully self-contained scripts. Tasks and workflows cannot be imported
  from other files currently. Please use `pyflyte package` or `pyflyte
  register` to handle those and then launch from the Flyte UI or `flytectl`

  Note: This command only works on regular Python packages, not namespace
  packages. When determining       the root of your project, it finds the
  first folder that does not have an __init__.py file.

Options:
  --remote                Whether to register and run the workflow on a Flyte
                          deployment
  -p, --project TEXT      Project to register and run this workflow in
  -d, --domain TEXT       Domain to register and run this workflow in
  --name TEXT             Name to assign to this execution
  --destination-dir TEXT  Directory inside the image where the tar file
                          containing the code will be copied to
  -i, --image TEXT        Image used to register and run.
  --service-account TEXT  Service account used when executing this workflow
  --wait-execution        Whether wait for the execution to finish
  --dump-snippet          Whether dump a code snippet instructing how to load
                          the workflow execution using flyteremote
  --help                  Show this message and exit.

Commands:
  setup.py  Run a [workflow|task] in a file using script mode
Signed-off-by: Samhita Alla <[email protected]>
@eapolinario
Bump codecov gh action and pin plugins requirements in tests (#1026)
7dd480b 
* Bump codecov gh action and pin plugins requirements in tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytedecks plugin name in requirements files

Signed-off-by: Eduardo Apolinario <[email protected]>

* Skip greatexpectations plugin tests on python 3.10

Signed-off-by: Eduardo Apolinario <[email protected]>

* Bump requirements for great-expectations plugin

Signed-off-by: Eduardo Apolinario <[email protected]>

* Regenerate modin plugin requirements file

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove `make setup` from plugins tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Revert "Remove `make setup` from plugins tests"

This reverts commit 3ba7348.

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@pingsutw @eapolinario
Add support list of flytetype in dataclass (#1057)
6567013 
* Add support list of flytetype in dataclass

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

* Add tests

Signed-off-by: Kevin Su <[email protected]>
@eapolinario @snyk-bot
fix: plugins/flytekit-aws-sagemaker/requirements.txt to reduce vulner…
c6f59cb 
…abilities (#1054)

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-COOKIECUTTER-2414281

Co-authored-by: snyk-bot <[email protected]>
@dependabot @eapolinario
Bump cookiecutter (#1058)
de3a7c9 
Bumps [cookiecutter](https://github.com/cookiecutter/cookiecutter) from 1.7.3 to 2.1.1.
- [Release notes](https://github.com/cookiecutter/cookiecutter/releases)
- [Changelog](https://github.com/cookiecutter/cookiecutter/blob/master/HISTORY.md)
- [Commits](cookiecutter/cookiecutter@1.7.3...2.1.1)

---
updated-dependencies:
- dependency-name: cookiecutter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@eapolinario
Bump flyteidl and other requirements (#1060)
deaaf46 
* Bump flyteidl and other requirements

Signed-off-by: Eduardo Apolinario <[email protected]>

* Regenerate using python 3.7

Signed-off-by: Eduardo Apolinario <[email protected]>

* Bump flyteidl min version and regenerate reqs

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix get client in flyte-cli commands (#1063)
1fa81e9 
* Replace fields of platform_config with dataclasses.replace in flyte-cli/main.py

Signed-off-by: Eduardo Apolinario <[email protected]>

* Remove with_parameters

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix port rewrite in the case of sandbox/demo cluster (#1064)
a99aade 
* Fix port rewrite in the case of sandbox/demo cluster

Signed-off-by: Eduardo Apolinario <[email protected]>

* Include endpoint in sandbox config

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
@sonjaer @eapolinario
Fix read authorization_metadata_key from public_client_config in _ref…
0e9114d 
…resh_credentials_from_command (#1065)

* add support for custom auth from env

Signed-off-by: Sonja Ericsson <[email protected]>

* Update flytekit/clis/flyte_cli/main.py

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* Update test_raw.py

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>

* fix

Signed-off-by: Sonja Ericsson <[email protected]>
@jeevb @eapolinario
Fix serialization of tasks with environment variables set (#1066)
94cc009 
Signed-off-by: Jeev B <[email protected]>
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-v1.0@ca4161b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 94cc009 differs from pull request most recent head 508301d. Consider uploading reports for the commit 508301d to get more accurate results

@@               Coverage Diff               @@
##             release-v1.0    #1067   +/-   ##
===============================================
  Coverage                ?   86.48%           
===============================================
  Files                   ?      260           
  Lines                   ?    24586           
  Branches                ?     2795           
===============================================
  Hits                    ?    21264           
  Misses                  ?     2845           
  Partials                ?      477

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4161b...508301d. Read the comment docs.

@samhita-alla @eapolinario
TypeTransformer for Numpy (#1027)
508301d 
* precommit

Signed-off-by: Samhita Alla <[email protected]>

* fix failing tests

Signed-off-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.