Fix port rewrite in the case of sandbox/demo cluster #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 86.50% 86.54% +0.04%
==========================================
Files 267 268 +1
Lines 24847 24872 +25
Branches 2797 2800 +3
==========================================
+ Hits 21493 21525 +32
+ Misses 2877 2870 -7
Partials 477 477 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jun 15, 2022
eapolinario
added a commit
that referenced
this pull request
Jun 17, 2022
* Fix port rewrite in the case of sandbox/demo cluster Signed-off-by: Eduardo Apolinario <[email protected]> * Include endpoint in sandbox config Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario [email protected]
TL;DR
Fix port rewrite in the case of sandbox/demo cluster
Type
Are all requirements met?
Complete description
We rewrite the flyteconsole port in case we detect that we're running on a sandbox/demo cluster. However, #992 made it so that
auth_typeis now read from the config file (as opposed to getting the default value).The fix is to ensure that the platform config for sandbox matches the one emitted by
flytectl.Tracking Issue
flyteorg/flyte#2615
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/