Allow struct/dataclass types to be used as default arguments #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Ruiz <[email protected]>
RobertoRRW
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
pingsutw
previously approved these changes
May 27, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 86.44% 86.45% +0.01%
==========================================
Files 260 261 +1
Lines 24618 24640 +22
Branches 2780 2782 +2
==========================================
+ Hits 21281 21303 +22
Misses 2862 2862
Partials 475 475 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
…taclasses Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
May 27, 2022
eapolinario
added a commit
that referenced
this pull request
Jun 17, 2022
* Allow struct/dataclass types to be used as default arguments Signed-off-by: Roberto Ruiz <[email protected]> * Add test case Signed-off-by: Eduardo Apolinario <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roberto Ruiz [email protected]
TL;DR
Pyflyte execution crashes when a task/worflow that takes a dataclass uses a default argument.
Type
Are all requirements met?
Complete description
Pyflyte attempts to convert struct type literal arguments for tasks/workflows from json string to its expected type.
I made it so the conversion isn't tried when it isn't necessary.
Tracking Issue
flyteorg/flyte#2555
Follow-up issue
NA