Fix serialization of tasks with environment variables set

[jeevb]

TL;DR

Fixes serialization of tasks with environment variables set.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Fixes PythonAutoContainer.get_container to handle the case where SerializationSettings.env is None (See:

flytekit/flytekit/configuration/__init__.py

Line 638 in 87d1390

env: Optional[Dict[str, str]] = None

). Currently fails with:

Traceback (most recent call last):
  File "/fn/bin/pyflyte", line 8, in <module>
    sys.exit(main())
  File "/fn/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/fn/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/fn/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/fn/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/fn/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/fn/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/fn/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/fn/lib/python3.9/site-packages/flytekit/clis/sdk_in_container/serialize.py", line 139, in workflows
    serialize_all(
  File "/fn/lib/python3.9/site-packages/flytekit/exceptions/scopes.py", line 160, in system_entry_point
    return wrapped(*args, **kwargs)
  File "/fn/lib/python3.9/site-packages/flytekit/clis/sdk_in_container/serialize.py", line 69, in serialize_all
    serialize_to_folder(pkgs, serialization_settings, local_source_root, folder)
  File "/fn/lib/python3.9/site-packages/flytekit/tools/repo.py", line 61, in serialize_to_folder
    loaded_entities = serialize(pkgs, settings, local_source_root, options=options)
  File "/fn/lib/python3.9/site-packages/flytekit/tools/repo.py", line 46, in serialize
    registrable_entities = get_registrable_entities(ctx, options=options)
  File "/fn/lib/python3.9/site-packages/flytekit/tools/serialize_helpers.py", line 77, in get_registrable_entities
    get_serializable(new_api_serializable_entities, ctx.serialization_settings, entity, options=options)
  File "/fn/lib/python3.9/site-packages/flytekit/tools/translator.py", line 573, in get_serializable
    cp_entity = get_serializable_task(entity_mapping, settings, entity)
  File "/fn/lib/python3.9/site-packages/flytekit/tools/translator.py", line 173, in get_serializable_task
    container = entity.get_container(settings)
  File "/fn/lib/python3.9/site-packages/flytekit/core/python_auto_container.py", line 159, in get_container
    env = {**settings.env, **self.environment} if self.environment else settings.env
TypeError: 'NoneType' object is not a mapping

[jeevb]

This test fails without the code change.

[jeevb]

@ggydush-fn: FYI.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.53%. Comparing base (87d1390) to head (098d13c).
Report is 1055 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   86.52%   86.53%   +0.01%     
==========================================
  Files         268      268              
  Lines       24877    24896      +19     
  Branches     2802     2804       +2     
==========================================
+ Hits        21525    21544      +19     
  Misses       2874     2874              
  Partials      478      478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

wow, great catch!