Do not deserialize default list/dict inputs using JSON in pyflyte run
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AND [ARGS]...
This command can execute either a workflow or a task from the commandline,
for fully self-contained scripts. Tasks and workflows cannot be imported
from other files currently. Please use `pyflyte package` or `pyflyte
register` to handle those and then launch from the Flyte UI or `flytectl`
Note: This command only works on regular Python packages, not namespace
packages. When determining the root of your project, it finds the
first folder that does not have an __init__.py file.
Options:
--remote Whether to register and run the workflow on a Flyte
deployment
-p, --project TEXT Project to register and run this workflow in
-d, --domain TEXT Domain to register and run this workflow in
--name TEXT Name to assign to this execution
--destination-dir TEXT Directory inside the image where the tar file
containing the code will be copied to
-i, --image TEXT Image used to register and run.
--service-account TEXT Service account used when executing this workflow
--wait-execution Whether wait for the execution to finish
--dump-snippet Whether dump a code snippet instructing how to load
the workflow execution using flyteremote
--help Show this message and exit.
Commands:
setup.py Run a [workflow|task] in a file using script mode
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
=======================================
Coverage 86.50% 86.51%
=======================================
Files 265 267 +2
Lines 24773 24790 +17
Branches 2787 2787
=======================================
+ Hits 21429 21446 +17
Misses 2867 2867
Partials 477 477 ☔ View full report in Codecov by Sentry. |
samhita-alla
changed the title
pyflyte runpyflyte run
eapolinario
approved these changes
Jun 1, 2022
eapolinario
pushed a commit
that referenced
this pull request
Jun 17, 2022
…AND [ARGS]... (#1033) This command can execute either a workflow or a task from the commandline, for fully self-contained scripts. Tasks and workflows cannot be imported from other files currently. Please use `pyflyte package` or `pyflyte register` to handle those and then launch from the Flyte UI or `flytectl` Note: This command only works on regular Python packages, not namespace packages. When determining the root of your project, it finds the first folder that does not have an __init__.py file. Options: --remote Whether to register and run the workflow on a Flyte deployment -p, --project TEXT Project to register and run this workflow in -d, --domain TEXT Domain to register and run this workflow in --name TEXT Name to assign to this execution --destination-dir TEXT Directory inside the image where the tar file containing the code will be copied to -i, --image TEXT Image used to register and run. --service-account TEXT Service account used when executing this workflow --wait-execution Whether wait for the execution to finish --dump-snippet Whether dump a code snippet instructing how to load the workflow execution using flyteremote --help Show this message and exit. Commands: setup.py Run a [workflow|task] in a file using script mode Signed-off-by: Samhita Alla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samhita Alla [email protected]
TL;DR
Default list/dict arguments are being deserialized by JSON when using the
pyflyte runcommand resulting in a JSON type error. The arguments should be deserialized only when sent as command-line arguments.Related Slack conversation:
https://flyte-org.slack.com/archives/CNMKCU6FR/p1654084316153379
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/