Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comma separate packages in pyflyte --pkgs #999

Merged
merged 1 commit into from
May 13, 2022
Merged

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

User reported frustration with the --pkgs switch. Users should be able to use comma-separated values in addition to specifying the click switch multiple times.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#2476

…indicating separate packages

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title allow users to just have one --pkgs switch, but have commas in there … Allow comma separate packages in pyflyte --pkgs May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #999 (1d2e9b9) into master (cc2a4e7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   86.33%   86.34%   +0.01%     
==========================================
  Files         255      255              
  Lines       24323    24357      +34     
  Branches     2768     2771       +3     
==========================================
+ Hits        21000    21032      +32     
- Misses       2851     2853       +2     
  Partials      472      472              
Impacted Files Coverage Δ
flytekit/clis/sdk_in_container/pyflyte.py 73.80% <100.00%> (+4.36%) ⬆️
tests/flytekit/unit/cli/pyflyte/test_package.py 89.83% <100.00%> (+0.54%) ⬆️
flytekit/configuration/file.py 82.63% <0.00%> (-0.06%) ⬇️
tests/flytekit/unit/configuration/test_internal.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2a4e7...1d2e9b9. Read the comment docs.

@wild-endeavor wild-endeavor merged commit 94629a4 into master May 13, 2022
eapolinario pushed a commit that referenced this pull request Jun 17, 2022
…indicating separate packages (#999)

Signed-off-by: Yee Hing Tong <[email protected]>
@eapolinario eapolinario mentioned this pull request Jun 17, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants