Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dot separated python packages does not work for pyflyte #2476

Closed
2 tasks done
sonjaer opened this issue May 11, 2022 · 3 comments
Closed
2 tasks done

[BUG] Dot separated python packages does not work for pyflyte #2476

sonjaer opened this issue May 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@sonjaer
Copy link
Contributor

sonjaer commented May 11, 2022

Describe the bug

Dot separated python packages does not work for pyflyte.

This doesn't work:

pyflyte --pkgs flyte_python_pipeline_sonjae.flyte_python_pipeline_sonjae_2 serialize workflows

but this does:

pyflyte --pkgs flyte_python_pipeline_sonjae --pkgs flyte_python_pipeline_sonjae_2 serialize workflows
@click.group("pyflyte", invoke_without_command=True)
@click.option(
    "-k",
    "--pkgs",
    required=False,
    multiple=True,
    callback=validate_package,
    help="Dot separated python packages to operate on.  Multiple may be specified  Please note that this "
    "option will override the option specified in the configuration file, or environment variable",
)

https://github.com/flyteorg/flytekit/blob/c011ef7cf47ac8ffc06c48e000cb309d9df99969/flytekit/clis/sdk_in_container/pyflyte.py#L29

Expected behavior

You should be able to pass

pyflyte --pkgs flyte_python_pipeline_sonjae,flyte_python_pipeline_sonjae_2

Additional context to reproduce

flytekit v1.0.1

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@sonjaer sonjaer added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 11, 2022
@wild-endeavor wild-endeavor added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels May 11, 2022
@wild-endeavor wild-endeavor modified the milestones: 1.0.1, 1.0.2 May 11, 2022
@wild-endeavor wild-endeavor self-assigned this May 12, 2022
@seunggs
Copy link

seunggs commented Jul 21, 2022

@sonjaer Hi what is a "package" in this case? Is this the name of the folder that the flyte workflow code is in?

@wild-endeavor
Copy link
Contributor

python package yes. dot-deliminated. so like a/b/c would be represented as a.b.c from the folder that a/ lives in. (and there would have to be init files in a, b, and c

@seunggs
Copy link

seunggs commented Jul 21, 2022

Ah ok - got it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

3 participants