Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass fileaccess data config to data persistence plugin #1004

Merged
merged 1 commit into from
May 16, 2022

Conversation

cosmicBboy
Copy link
Contributor

@cosmicBboy cosmicBboy commented May 16, 2022

Signed-off-by: Niels Bantilan [email protected]

TL;DR

Prior to this change, the data persistence plugin used in the FileAccessProvider.put_data method would not use the correct data config (effectively it was empty). This PR passes the FileAccessProvider object's data_config into the appropriate plugin.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (7c915bb) to head (8cebf81).
Report is 1086 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files         255      255           
  Lines       24379    24379           
  Branches     2774     2774           
=======================================
  Hits        21065    21065           
  Misses       2842     2842           
  Partials      472      472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy cosmicBboy merged commit 5907e76 into master May 16, 2022
@cosmicBboy cosmicBboy deleted the fix-data-persist branch May 16, 2022 19:02
eapolinario pushed a commit that referenced this pull request Jun 17, 2022
@eapolinario eapolinario mentioned this pull request Jun 17, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants