ci: trigger releases #3508
Merged
ci: trigger releases #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes finalizeWithdrawalTransaction not payable. Having this function be payable created test failures because it was confusing whether funds should be sent to that function.
Adds a fault status API endpoint so people can easily query if the node is currently diverged. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixes a small error in the message-relayer canary action that would cause it to fail to build. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Minor README update after questions from a third party. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Will Cory <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixes a bug in the fault detector that would cause errors when running on testnets with very short fault proof windows. Now handles this case explicitly. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Updates GovernanceToken to use seaport style comments. Minor fix, but might as well be consistent across the codebase. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up the config check task so it's slightly easier to maintain. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Simplifies XDM initialization by moving all input variables into the constructor. This was the best I could do, we still need an initializer because of the stuff that the base contract inherits. The primary benefit of this change is that it means we never have to put any parameters into the initializer, which means we can be very certain about parameters before we perform the upgrade.
Bumps [parse-url](https://github.com/IonicaBizau/parse-url) from 6.0.0 to 6.0.5. - [Release notes](https://github.com/IonicaBizau/parse-url/releases) - [Commits](IonicaBizau/parse-url@6.0.0...6.0.5) --- updated-dependencies: - dependency-name: parse-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cleans up spacers to all be private, introduces types to the custom spacer natspec, and renames spacer variables to include slot, offset, and length so we can automate checks. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Mark Tyneway <[email protected]>
* ops: Add oneshot deployment container Adds a one-shot container that runs both op-geth and op-node in the same container. It also embeds the configuration for a specific network in the container in order to cut down on deployment errors. See README.md for full usage and architecture. * remove env var
…sit spec (#3440) * fix(ctb): M-03 Eth can be send to undeliverable recipient * fix(ctb): M-07 CrossDomainMessenger allows sending messages to unrelayable addresses" * fix(ctb): L-01 Improve deposit docs * fix(ctb): L-09 Misleading inline documentation * fix(ctb): Standard Bridge does not support tokens with transfer fees * fix(ctb): N-07 Unexplained literal values
Bumps ethers to 5.7.0 everywhere. Co-authored-by: Matthew Slipper <[email protected]>
* fix(ctb): L-06 Circumventable requirement that owner and proposer are distinct Overrides the default transferOwnership function to enforce this requirement. Likewise in the initialize function. * chore: Regen bindings * update more file * fix devnet + weth9 * try to fix weth9 again * one more weth9 * update snapshot Co-authored-by: Matthew Slipper <[email protected]>
* fix(ctp): Drippie Spearbit issue 45 Fixes Spearbit issue 45, saves gas by using calldata parameters instead of memory parameters. * fix(ctp): Drippie Spearbit issue 44 Fixes Spearbit issue 44, documents the count variable and increments count before external calls. * fix(ctp): Drippie Spearbit issue 42 Fixes Spearbit issue 42, saves gas by removing extra SLOADs. * fix(ctp): Drippie Spearbit issue 35 Fixes Spearbit issue 35, corrects contract layout ordering. * fix(ctp): Drippie Spearbit issue 34 Fixes Spearbit issue 34, adds natspec where incomplete. * fix(ctp): Drippie Spearbit issue 32 and 33 Fixes Spearbit issues 32 and 33, clarifies the behavior of the executable function to revert instead of returning false, and removes an unnecessary check as a result. * fix(ctp): Drippie Spearbit issue 31 Fixes Spearbit issue 31, requires explicit opt-in for reentrant drip execution. * fix(ctp): Drippie Spearbit issue 28 Fixes Spearbit issue 28, better documentation of the behavior of execution checks in the drip function. * fix(ctp): Drippie Spearbit issue 21 Fixes Spearbit issue 21, use MIT licensed version of Solmate. * fix(ctp): Drippie Spearbit issue 25 Fixes Spearbit issue 25, reorders DripStatus enum for clarity. * fix(ctp): Drippie Spearbit issue 24 Fixes Spearbit issue 24, use call with value over transfer to avoid future gas issues. * fix(ctp): Drippie Spearbit issue 22 Fixes Spearbit issue 22, removes unnecessary gas parameter. * fix(ctp): Drippie Spearbit issue 39 Fixes Spearbit issue 39, updates Solidity to latest version. Co-authored-by: Mark Tyneway <[email protected]>
* proxyd: Fix error message in tests The custom error message wasn't being carried over in batch responses. * review fixes Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* fix: M-08 Upgradeability inconsistencies Standardizes the use of storage gaps. Note that we only include a storage gap in contracts which are inherited in our system, not in the childless children * feat: Add custom natspec tag 'upgradeable' * docs(ctb): document natspec tag 'semver' * chore: add changeset
Fixes a bug in the DTL that would break sync when addresses are changed in the AddressManager. Slightly reduces complexity at the same time by removing an additional request. Co-authored-by: Matthew Slipper <[email protected]> Co-authored-by: Mark Tyneway <[email protected]>
* ci: Print forge version * chore(ci): Download and verify codecov uploader * chore(ci): Upload go coverage reports * ci(ctb): Upload forge coverage output * ci(ctb): Add lcov output command * ci: Move codecov uploader install to ci-builder * ci: Pass on codecov failure * ci: Download codecov in ci-builder
* fix(ctb): N-03 Assert for impossible condition * fix(ctb): N-04 Confusing else conditions in ProxyAdmin * chore: Regen bindings * chore: regen bindings Co-authored-by: Matthew Slipper <[email protected]>
* fix: Emit DepositFailed in L2 Bridge * chore: Regen bindings * chore: regen bindings Co-authored-by: Matthew Slipper <[email protected]>
There were open zeppelin contracts defined in the top level `package.json` as well as in each of the individual packages. We want to be very explicit with the version of the contract dependencies that are used. I believe that the versions local to the packages were being used instead of the globally defined versions, removing them from the top level `package.json` will ensure this. Co-authored-by: Matthew Slipper <[email protected]>
🦋 Changeset detectedLatest commit: b982aae The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release develop => master