fix(ctp): Drippie Spearbit audit fixes #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb2c556 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
force-pushed
the
sc/drippie-audit-fixes
branch
3 times, most recently
from
779d3d3
to
a1072f9
Compare
Fixes Spearbit issue 45, saves gas by using calldata parameters instead of memory parameters.
Fixes Spearbit issue 44, documents the count variable and increments count before external calls.
Fixes Spearbit issue 42, saves gas by removing extra SLOADs.
Fixes Spearbit issue 35, corrects contract layout ordering.
Fixes Spearbit issue 34, adds natspec where incomplete.
Fixes Spearbit issues 32 and 33, clarifies the behavior of the executable function to revert instead of returning false, and removes an unnecessary check as a result.
Fixes Spearbit issue 31, requires explicit opt-in for reentrant drip execution.
Fixes Spearbit issue 28, better documentation of the behavior of execution checks in the drip function.
Fixes Spearbit issue 21, use MIT licensed version of Solmate.
Fixes Spearbit issue 25, reorders DripStatus enum for clarity.
Fixes Spearbit issue 24, use call with value over transfer to avoid future gas issues.
Fixes Spearbit issue 22, removes unnecessary gas parameter.
Fixes Spearbit issue 39, updates Solidity to latest version.
smartcontracts
force-pushed
the
sc/drippie-audit-fixes
branch
from
a1072f9
to
1247b2b
Compare
maurelian
approved these changes
Sep 8, 2022
|
@tynes can you please review? Don't want this to go stale. |
tynes
approved these changes
Sep 19, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes individual commits for each audit issue that I felt was worth fixing. No "high" or "critical" severity bugs were found as part of the audit and making this PR public does not put any existing funds at risk.