Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate codecoverage and upload to CodeCov #3348

Merged
merged 8 commits into from
Sep 19, 2022
Merged

Generate codecoverage and upload to CodeCov #3348

merged 8 commits into from
Sep 19, 2022

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Sep 7, 2022

Changes CI to upload code coverage results generated by the go modules and contracts-bedrock package.

This job doesn't run on this PR because of the Check Changed step, but it was tested in previous iterations of this branch by disabling that step. The results can be seen here.

Improvements which are not included in this PR but will be added later:

  1. Moving the codecov uploader installation to the ci-builder image.
  2. Failing in CI when the coverage threshold decreases.
  3. Adding a coverage badge to the README.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

🦋 Changeset detected

Latest commit: dac2938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/ci-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@maurelian maurelian marked this pull request as ready for review September 15, 2022 14:30
@maurelian maurelian changed the title test: CodeCov Add codecoverage generate with CodeCov Sep 15, 2022
.circleci/config.yml Outdated Show resolved Hide resolved
@maurelian maurelian changed the title Add codecoverage generate with CodeCov Generate codecoverage and upload to CodeCov Sep 19, 2022
@mslipper mslipper merged commit 7375a94 into develop Sep 19, 2022
@mslipper mslipper deleted the codecov branch September 19, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ops Area: ops A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants