Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nft: add view keyword to functions in IOptimismMintableERC721 #3496

Merged
merged 3 commits into from
Sep 15, 2022
Merged

nft: add view keyword to functions in IOptimismMintableERC721 #3496

merged 3 commits into from
Sep 15, 2022

Conversation

sam-goldman
Copy link
Contributor

Wasn't included in the OpenZeppelin audit report, but a few functions in IOptimismMintableERC721 should have the view keyword.

Closes #3452.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 75a5cef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels Sep 15, 2022
@sam-goldman sam-goldman mentioned this pull request Sep 15, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 8c189ba into develop Sep 15, 2022
@mergify mergify bot deleted the ctp/erc721-iface branch September 15, 2022 21:31
@mergify mergify bot removed the on-merge-train label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@tynes tynes tynes approved these changes

Assignees
No one assigned
Labels
A-op-bindings Area: op-bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-goldman @tynes @smartcontracts