-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Emit DepositFailed in L2 Bridge #3450
Conversation
🦋 Changeset detectedLatest commit: 866780d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b3ba82b
to
5fe814e
Compare
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
1311d93
to
ad4b0ac
Compare
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
Will approve after snapshot and bindings are rebuilt |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
The
L2StandardBridge
contract did not emit aDepositFailed
event when afinalizeDeposit
call fails and instead always emitted aDepositFinalized
event.This was fixed by adding a boolean return value to
StandardBridge.finalizeBridgeERC20
, and emitting the correct event based on the return value.The L1 bridge is not affected by this issue because it did not previously have a failure case which could occur in the minting of the deposited token.
Tests
Existing test cases have been extended to validate that the proper events are emitted.