Ensure the Oracle's owner and proposer accounts are unique #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80fd6ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
tynes
reviewed
Sep 13, 2022
|
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
… distinct Overrides the default transferOwnership function to enforce this requirement. Likewise in the initialize function.
|
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
approved these changes
Sep 16, 2022
mslipper
approved these changes
Sep 18, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The oracle previously enforced that the
proposercould not be updated to match theowner, however it didn't prevent theownerfrom being updated to match theproposer.Tests
Existing tests have been updated to check this.