fix(dtl): sync bug when addresses change #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8b14c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
|
We should cut a canary release here an ensure it syncs all the networks |
Fixes a bug in the DTL that would break sync when addresses are changed in the AddressManager. Slightly reduces complexity at the same time by removing an additional request.
smartcontracts
force-pushed
the
sc/dtl-sync-bug-fix
branch
from
3dac8f0
to
2d23a88
Compare
Inphi
approved these changes
Aug 18, 2022
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
mslipper
approved these changes
Sep 6, 2022
tynes
approved these changes
Sep 19, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the DTL that would break sync when addresses are changed
in the AddressManager. Slightly reduces complexity at the same time by
removing an additional request.
Note that this does NOT impact mainnet because we have never changed addresses.