[Maps] Isolate maps-setting froms maps_legacy #92918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
chore
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
approved these changes
Mar 9, 2021
src/plugins/maps_ems/public/service_settings/service_settings.ts
Outdated
Show resolved
Hide resolved
nreese
reviewed
Mar 11, 2021
| @@ -107,3 +107,4 @@ pageLoadAssetSize: | |||
| osquery: 107090 | |||
| fileUpload: 25664 | |||
| banners: 17946 | |||
| mapsEms: 26072 | |||
There was a problem hiding this comment.
Could mapsLegacy be reduced since this was broken out?
Running node scripts/build_kibana_platform_plugins.js --update-limits it looks like mapsLegacy could be set to 87859 which is 5k above the current size.
|
@elasticmachine merge upstream |
stratoula
approved these changes
Mar 15, 2021
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Mar 15, 2021
thomasneirynck
added
the
auto-backport
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Mar 15, 2021
Creates a new plugins, maps_ems, with `map.*` configs and shared EMS-settings. `maps_legacy` now only supports the `region_map` and `coordinate_map` plugins. # Conflicts: # packages/kbn-optimizer/limits.yml
thomasneirynck
added a commit
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76532
Partially addresses #89304
mapconfiguration and ems-settings in a separate plugin, calledmapsEmsmaps_legacydependencies to justregion_mapandtile_map.maps_legacynow only contains common UX, which is mostly leaflet-based. When removingregion_mapandtile_map,mapsLegacycan be removed just as well ([Breaking change] Remove Coordinate map and region map visualizations #81703). Removing these plugins, will also resolve the maps-dependencies onkibana_legacyRemove kibana_legacy plugin #76905.This PR needs a few follow-on PRs: