Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kibana_legacy plugin #76905

Closed
35 of 37 tasks
flash1293 opened this issue Sep 8, 2020 · 4 comments · Fixed by #118672
Closed
35 of 37 tasks

Remove kibana_legacy plugin #76905

flash1293 opened this issue Sep 8, 2020 · 4 comments · Fixed by #118672
Assignees
@stratoula
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:FieldFormatters Feature:NP Migration impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort :ml refactoring Team:Monitoring Stack Monitoring team Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@flash1293
Copy link
Contributor

flash1293 commented Sep 8, 2020 •
edited by exalate-issue-sync bot
Loading

The kibana_legacy plugin contains deprecated functionality. All consumers should migrate away from it mid-term so the plugin can be retired completely. This issue tracks all of the places, feel free to open sub-issues.

This list doesn't track things which are scheduled to be removed with 8.0 (dashboard mode, default app id, timelion)

start.loadFontAwesome references the font awesome loader exposed via contract - it should be migrated to use EUI icons instead.

  • dashboard @elastic/kibana-app
    • configureAppAngularModule
    • addFatalError
    • AngularHttpError
    • subscribeWithScope
  • discover @elastic/kibana-app
    • initAngularBootstrap
    • configureAppAngularModule
    • KbnAccessibleClickProvider
    • PrivateProvider
    • PromiseServiceCreator
    • registerListenEventListener
    • watchMultiDecorator
    • createTopNavDirective
    • createTopNavHelper
    • formatMsg
    • formatStack
    • subscribeWithScope
    • addFatalError
    • start.loadFontAwesome
    • .truncate-by-height (global CSS class set by legacy plugin)
  • data @elastic/kibana-app-arch
    • .truncate-by-height (global CSS class set by legacy plugin)
  • vis_type_table @elastic/kibana-app
    • initAngularBootstrap
  • region_map @elastic/kibana-gis
    • start.loadFontAwesome
  • tile_map @elastic/kibana-gis
    • start.loadFontAwesome
  • vis_type_vislib @elastic/kibana-app
    • start.loadFontAwesome
  • ml @elastic/machine-learning
  • monitoring @elastic/stack-monitoring-ui [Monitoring] Remove kibana_legacy plugin #99716
    • start.loadFontAwesome
  • graph @elastic/kibana-app
    • start.loadFontAwesome
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added Team:AppArch [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Monitoring Stack Monitoring team labels Sep 14, 2020
@flash1293 flash1293 added the :ml label Sep 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this issue Nov 23, 2020
Merged
3 tasks
@thomasneirynck thomasneirynck mentioned this issue Mar 1, 2021
Merged
@streamich
Copy link
Contributor

Place where App Services should remove .truncate-by-height reference:

image

@streamich streamich added Feature:FieldFormatters refactoring technical debt Improvement of the software architecture and operational architecture labels May 4, 2021
@thomasneirynck
Copy link
Contributor

wrt the region and coordinate maps dependencies:

These plugins will be removed in 8.0 (#81703), removing the dependency on kibana_legacy.

@igoristic igoristic mentioned this issue May 10, 2021
Closed
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@stratoula stratoula mentioned this issue Jul 6, 2021
Closed
@stratoula stratoula mentioned this issue Sep 29, 2021
Merged
@timroes timroes mentioned this issue Sep 29, 2021
Closed
@stratoula stratoula self-assigned this Nov 16, 2021
@stratoula stratoula mentioned this issue Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:FieldFormatters Feature:NP Migration impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort :ml refactoring Team:Monitoring Stack Monitoring team Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes the kibana_legacy plugin stratoula/kibana
5 participants
@flash1293 @thomasneirynck @streamich @elasticmachine @stratoula