Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes the kibana_legacy plugin #118672

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Removes the kibana_legacy plugin #118672

merged 8 commits into from
Nov 24, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 16, 2021 •
edited
Loading

Summary

Closes #76905
Closes #99716
Closes #115525

This PR removes the kibana legacy plugin from kibana. To achieve this:

  • We have moved the formatMsg function from kibana_legacy plugin to monitoring and canvas plugins
  • We have moved the font-awesome library, necessary for graph, to the graph plugin

@stratoula stratoula mentioned this pull request Nov 16, 2021
Closed
3 tasks
@stratoula stratoula requested a review from flash1293 November 16, 2021 18:42
@stratoula
Copy link
Contributor Author

@flash1293 would you like to take a look before I publish it?

@stratoula stratoula changed the title Removes kibana_legacy plugin Removes the kibana_legacy plugin Nov 16, 2021
@flash1293
Copy link
Contributor

@stratoula LGTM, thanks :)

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0 technical debt Improvement of the software architecture and operational architecture labels Nov 17, 2021
@stratoula stratoula marked this pull request as ready for review November 17, 2021 10:57
@stratoula stratoula requested review from a team as code owners November 17, 2021 10:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

mshustov
mshustov approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the core changes

kertal
kertal approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery team owned code LGTM, tested 🥣 a-la-carte, Graph icons are still there. Graph is feeling proud of being now the only owner of the awesome font 🎉

peteharverson
peteharverson approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML code changes LGTM

mbondyra
mbondyra approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis-editors changes look good, NICE 👏🏼

@weltenwort weltenwort self-requested a review November 18, 2021 13:11
@flash1293
Copy link
Contributor

@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices changes LGTM, great work!

ThomThomson
ThomThomson approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1073 1074 +1
graph 142 155 +13
kibanaLegacy 23 - -23
monitoring 437 438 +1
total -8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaLegacy 8 - -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1020.4KB 1020.4KB -2.0B
graph 390.5KB 444.6KB +54.1KB
kibanaLegacy 57.3KB - -57.3KB
monitoring 435.5KB 436.4KB +930.0B
total -2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.4KB 18.1KB +778.0B
graph 7.1KB 7.1KB -27.0B
kibanaLegacy 3.6KB - -3.6KB
ml 37.7KB 37.7KB -28.0B
monitoring 23.7KB 23.6KB -142.0B
total -3.1KB
Unknown metric groups

API count

id before after diff
kibanaLegacy 11 - -11

async chunk count

id before after diff
graph 1 2 +1
kibanaLegacy 1 - -1
total -0

miscellaneous assets size

id before after diff
graph 0.0B 928.6KB ⚠️ +928.6KB
kibanaLegacy 928.6KB - -928.6KB
total -0.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit cccc54f into elastic:main Nov 24, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 24, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@stratoula @kibanamachine @dmlemeshko
Removes the kibana_legacy plugin (#118672)
1afa518 
* Removes kibana_legacy plugin

* Update translations

* Move functions to canvas and monitpring plugins

Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@stratoula @kibanamachine @TinLe
Removes the kibana_legacy plugin (elastic#118672)
5a59e73 
* Removes kibana_legacy plugin

* Update translations

* Move functions to canvas and monitpring plugins

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@jloleysens jloleysens jloleysens approved these changes

@peteharverson peteharverson peteharverson approved these changes

@mbondyra mbondyra mbondyra approved these changes

@mshustov mshustov mshustov approved these changes

@weltenwort weltenwort weltenwort approved these changes

@kertal kertal kertal approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.1.0
Projects
None yet
Milestone
No milestone