Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline formatMsg helper into monitoring and canvas plugins #118463

Closed

Conversation

DianaDerevyankina
Copy link
Contributor

Summary

Inlined code of src/plugins/kibana_legacy/public/notify/lib/format_msg.ts to monitoring and canvas plugins.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@DianaDerevyankina DianaDerevyankina self-assigned this Nov 12, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1061 1062 +1
monitoring 445 446 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1015.0KB 1015.0KB -2.0B
monitoring 438.0KB 438.9KB +930.0B
total +928.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 17.4KB 18.1KB +778.0B
monitoring 23.7KB 23.6KB -142.0B
total +636.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@stratoula
Copy link
Contributor

Closing this in favor of #118672
I moved the changes introduced to this PR in a bigger one that actually removes the kibana_legacy plugin.

@stratoula stratoula closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants