Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] maps_legacy async bundle is loaded on startup #92664

Closed
flash1293 opened this issue Feb 24, 2021 · 3 comments · Fixed by #96093
Closed

[Maps] maps_legacy async bundle is loaded on startup #92664

flash1293 opened this issue Feb 24, 2021 · 3 comments · Fixed by #96093
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0

Comments

@flash1293
Copy link
Contributor

flash1293 commented Feb 24, 2021

Kibana version: 7.12 BC2

Describe the bug: On loading any page of Kibana, the async bundle of the maps_legacy bundle is loaded right away. It should only be loaded if it's actually required. It seems like all of the building blocks are in place, but an oversight placed it into the setup routine of the plugin (due to an interaction between region_map and tile_map)

Steps to reproduce:

  1. Open Kibana home page
  2. Observe /bundles/plugin/mapsLegacy/mapsLegacy.chunk.1.js being loaded

Expected behavior:
This bundle shouldn't be loaded.

Any additional context:
Path how it gets loaded in the setup phase:

const getBaseMapsVis = () => new BaseMapsVisualizationProvider();

this._mapIsLoaded = this._makeKibanaMap();

const modules = await lazyLoadMapsLegacyModules();

const { KibanaMap, L, ServiceSettings } = await import('./lazy');

triggered by

BaseMapsVisualization: mapsLegacy.getBaseMapsVis(),

@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck self-assigned this Feb 25, 2021
@thomasneirynck thomasneirynck changed the title maps_legacy async bundle is loaded on startup [Maps] maps_legacy async bundle is loaded on startup Feb 25, 2021
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Feb 25, 2021

I can take a look at this. We need to remove the dependency from Vega from maps_legacy (#89304), so this could be part of that refactoring effort.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Apr 6, 2021

this was fixed by #92918 and #96093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants