Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Decouple maps and maps_legacy config dependencies #64810

Closed
kindsun opened this issue Apr 29, 2020 · 1 comment
Closed

[Maps] Decouple maps and maps_legacy config dependencies #64810

kindsun opened this issue Apr 29, 2020 · 1 comment

Comments

@kindsun
Copy link
Contributor

kindsun commented Apr 29, 2020

While working on #64668, it became increasingly evident how intertwined our map configurations are between legacy and new Maps. Here are a few things we might do to improve this situation:

  • Audit current config schema and determine if all parts are used. Revise, add, and remove chunks as necessary
  • Consider having entirely different configurations for maps_legacy and maps even at the risk of repeating values and remove maps dependency on maps_legacy
  • Change map prefix to maps for consistency
  • Maybe related to the last 2, store more new Maps configuration values under xpack.maps prefix
  • Reconsider tilemap prefix
  • Reconsider where tilemap configurations live since they're required for ServiceSettings
@nreese
Copy link
Contributor

nreese commented Apr 12, 2021

closed by #92918

@nreese nreese closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants