-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Migrate Maps server to NP #66510
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
I am getting the error "log [16:32:45.317] [fatal][root] { ValidationError: child "xpack" fails because [child "maps" fails because ["showMapsInspectorAdapter" is not allowed]]" with |
|
@thomasneirynck @nreese This is ready for another pass when you have a chance. A few things to note since this was last reviewed:
|
x-pack/plugins/maps/server/maps_telemetry/collectors/register.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment remaining about removing some ts-ignore
lgtm
code review, tested in chrome
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Pulling this out as a separate PR from #65079 since it has a pretty large footprint on its own. Migrates the remaining pieces on the Maps server side to NP. Includes:
getInjectedVarFunc
references and connect map configThere are a few aspects of Maps in NP worth future passes that I noticed during this migration. I'll generate issues for several I've listed below and any others I think of. Offhand, this might include:
server/plugin.ts
. Maybe move sample data and tutorial registration to a separate file