Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Maps] Isolate maps-setting froms maps_legacy (#92918) #94588

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

thomasneirynck
Copy link
Contributor

Backports the following commits to 7.x:

Creates a new plugins, maps_ems, with `map.*` configs and shared EMS-settings. `maps_legacy` now only supports the `region_map` and `coordinate_map` plugins.
# Conflicts:
#	packages/kbn-optimizer/limits.yml
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
mapsEms - 138 +138
mapsLegacy 182 50 -132
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
mapsEms - 238.1KB ⚠️ +238.1KB
mapsLegacy 520.7KB 283.1KB -237.6KB
regionMap 285.2KB 285.3KB +55.0B
total +585.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 143.3KB 143.3KB -9.0B
mapsEms - 10.7KB +10.7KB
mapsLegacy 78.9KB 71.2KB -7.8KB
mapsLegacyLicensing 3.4KB 3.4KB -12.0B
regionMap 19.4KB 19.7KB +289.0B
tileMap 18.0KB 17.9KB -77.0B
visTypeVega 57.4KB 57.4KB -27.0B
total +3.1KB
Unknown metric groups

async chunk count

id before after diff
mapsEms - 1 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 366ad49 into elastic:7.x Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants