Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple maps plugin and vis_type_vega plugin from maps_legacy plugin #76532

Closed
nreese opened this issue Sep 2, 2020 · 1 comment · Fixed by #92918
Closed

Decouple maps plugin and vis_type_vega plugin from maps_legacy plugin #76532

nreese opened this issue Sep 2, 2020 · 1 comment · Fixed by #92918
Assignees
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0

Comments

@nreese
Copy link
Contributor

nreese commented Sep 2, 2020

maps_legacy plugin contains lots of functionality. Some used by every mapping solution in Kibana. Other used specifically by tile_map and region_map plugin.

maps plugin and vis_type_vega plugin need to be decoupled from maps_legacy plugin making it possible to prune maps_legacy, tile_map, and region_map plugins without effecting maps plugin and vis_type_vega plugin.

I propose making a new plugin, maps_common under src/plugins that would contain only the common functionality used by all mapping plugins.

  • All mapping kibana.yml configurations from maps_legacy
@nreese nreese added discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants