Eliminate split packages #78166
Assignees
Labels
Comments
This was referenced Sep 22, 2021
This was referenced Sep 22, 2021
This was referenced Sep 23, 2021
This was referenced Oct 4, 2021
ChrisHegarty
added a commit
that referenced
this issue
Oct 5, 2021
With LUCENE-10118 integrated, we can now remove the package -private dependency with org.apache.lucene.index.OneMergeHelper, and intercept the info/log messages coming from merge threads. This change alters the logging a little, but the fundamental information captured remains more or less the same. It is worth noting that since the merges occur asynconously, the actual post-merge statistics are best captured when the merge thread completes its operation - which is the case with the change in this PR. relates (#78166)
This was referenced Oct 6, 2021
This was referenced Nov 25, 2021
This was referenced Dec 21, 2021
|
Hello @ChrisHegarty , it's look like the changes in are breaking backwards compatibility (in a minor version update) i'm getting error like Caused by: java.lang.NoClassDefFoundError: org/elasticsearch/common/xcontent/json/JsonXContent after updating Elasticsearch client please see jobrunr/jobrunr#291 |
|
@ChrisHegarty see #82357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To allow for the future modularization of Elasticsearch with Java Modules, there are a number preparatory tasks that need be completed. This is one such task: eliminate split packages.
Split packages with Lucene:
server/src/main/java/org/apache/lucene/document/BinaryRange.java(Fix split package org.apache.lucene.document #78186)server/src/main/java/org/apache/lucene/index/OneMergeHelper.javaLUCENE-10118ES leverage LUCENE-10118server/src/main/java/org/apache/lucene/search/grouping/CollapsingTopDocsCollector.java(Fork FirstPassGroupingCollector into a custom single pass collector #79224)server/src/main/java/org/apache/lucene/search/grouping/CollapsingDocValuesSource.java(Fork FirstPassGroupingCollector into a custom single pass collector #79224)server/src/main/java/org/apache/lucene/search/uhighlight/BoundedBreakIteratorScanner.java(Avoid unnecessary split package with lucene-highlighter #78099)server/src/main/java/org/apache/lucene/search/uhighlight/Snippet.javaserver/src/main/java/org/apache/lucene/search/uhighlight/CustomPassageFormatter.javaserver/src/main/java/org/apache/lucene/search/uhighlight/CustomUnifiedHighlighter.javaserver/src/main/java/org/apache/lucene/search/uhighlight/CustomFieldHighlighter.javaserver/src/main/java/org/apache/lucene/search/grouping/CollapseTopFieldDocs.java(Fork FirstPassGroupingCollector into a custom single pass collector #79224)server/src/main/java/org/apache/lucene/search/vectorhighlight/CustomFieldQuery.java(Fix split package org.apache.lucene.search.vectorhighlight #81041)server/src/main/java/org/apache/lucene/index/ShuffleForcedMergePolicy.javaLUCENE-10132ES leverage LUCENE-10132server/src/main/java/org/apache/lucene/util/CombinedBitSet.java(Fix split package org.apache.lucene.util #78189 )server/src/main/java/org/apache/lucene/queries/SpanMatchNoDocsQuery.java(Fix split package org.apache.lucene.queries #81043)server/src/main/java/org/apache/lucene/queries/BinaryDocValuesRangeQuery.java(Fix split package org.apache.lucene.queries #81043)server/src/main/java/org/apache/lucene/queries/BlendedTermQuery.java(Fix split package org.apache.lucene.queries #81043)server/src/main/java/org/apache/lucene/queryparser/classic/XQueryParser.javaPreparatory change committed in LUCENE-10115ES leverage LUCENE-10115 (Fix split package org.apache.lucene.queryparser.classic #78307)server/src/main/java/org/apache/lucene/analysis/miscellaneous/DisableGraphAttribute.java(Fix split package org.apache.lucene.analysis.miscellaneous #78205)server/src/main/java/org/apache/lucene/analysis/miscellaneous/DuplicateByteSequenceSpotter.javaserver/src/main/java/org/apache/lucene/analysis/miscellaneous/DuplicateSequenceAttributeImpl.javaserver/src/main/java/org/apache/lucene/analysis/miscellaneous/DeDuplicatingTokenFilter.javaserver/src/main/java/org/apache/lucene/analysis/miscellaneous/DuplicateSequenceAttribute.javaserver/src/main/java/org/apache/lucene/analysis/miscellaneous/DisableGraphAttributeImpl.javaserver/src/main/java/org/apache/lucene/search/XCombinedFieldQuery.java(Remove XCombinedFieldQuery workaround #77978)server/src/main/java/org/apache/lucene/search/XMultiNormsLeafSimScorer.java#### Split packages within ES itself:
Fix split package in reindex module(Fix split package in reindex module #78141)Fix split package in search business rules module(Fix split package in search business rules module #78139)Move ccr info/usage actions into ccr module(Move ccr info/usage actions into ccr module #78137)Fix split packages in external test modules(Fix split packages in external test modules #78136)Fix split package in annotated text plugin(Fix split package in annotated text plugin #78133)Fix split package in netty4 module(Fix split package in netty4 module #78132)Fix split package in mapper-extras module(Fix split package in mapper-extras module #78131)Fix split package in aggs-matrix-stats module(Fix split package in aggs-matrix-stats module #78130)Fix split package in keystore-cli(Fix split package in keystore-cli #78047)Fix split packages in analysis-ukranian plugin(Fix split packages in analysis-ukranian plugin #78046)Fix split package in analysis-smartcn plugin(Fix split package in analysis-smartcn plugin #78045)Fix split package in analysis-phonetic plugin(Fix split package in analysis-phonetic plugin #78044)Fix split package in analysis-nori plugin(Fix split package in analysis-nori plugin #78040)Fix split package in analysis-kuromoji plugin(Fix split package in analysis-kuromoji plugin #78039)Fix split package in analysis-icu plugin(Fix split package in analysis-icu plugin #78037)Fix split packages in plugin cli(Fix split packages in plugin cli #78027)Fix split package org.elasticsearch.common.xcontent(Fix split package org.elasticsearch.common.xcontent #78831)Fix split package org.elasticsearch.client(Fix split package org.elasticsearch.client #81984)The text was updated successfully, but these errors were encountered: