Fix split package in keystore-cli #78047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keystore-cli contains cli command classes for reading and writing the elasticsearch-keystore. These classes need access to the save methods of the KeyStoreWrapper, but those are package private. This change openes those methods to make them available. Note that setString was already public, only setFile and a couple minor methods were necessary to open up. Additionally, some methods from bootstrap for reading the keystore needed to be accessible to tests. This change moves those to a public utility class, as they were already static.
rjernst
added
>non-issue
v8.0.0
:Core/Infra/CLI
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine run elasticsearch-ci/part-2 |
ChrisHegarty
approved these changes
Sep 21, 2021
| */ | ||
| public class BootstrapUtil { | ||
|
|
||
| /** |
There was a problem hiding this comment.
Trivially, you could optionally add a private no-args constructor to BootstrapUtil, since it would appear to be a non-instantiable class exposing static utility methods.
💔 Backport failed
You can use sqren/backport to manually backport by running |
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keystore-cli contains cli command classes for reading and writing
the elasticsearch-keystore. These classes need access to the save
methods of the KeyStoreWrapper, but those are package private. This
change openes those methods to make them available. Note that setString
was already public, only setFile and a couple minor methods were
necessary to open up. Additionally, some methods from bootstrap for
reading the keystore needed to be accessible to tests. This change moves
those to a public utility class, as they were already static.