Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix split package in annotated text plugin #78133

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Fix split package in annotated text plugin #78133

merged 2 commits into from
Sep 21, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 21, 2021

The annotated text mapper plugin reuses package names from server. This
commit moves the implementation classes into an annotated text package
specifically for the plugin.

@rjernst
Fix split package in annotated text plugin
6fd9f95 
The annotated text mapper plugin reuses package names from server. This
commit moves the implementation classes into an annotated text package
specifically for the plugin.
@rjernst rjernst added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.16.0 auto-backport-and-merge labels Sep 21, 2021
@rjernst rjernst requested a review from jtibshirani September 21, 2021 16:45
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

jtibshirani
jtibshirani approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me! It seems like we're converging on a naming convention of org.elasticsearch.index.mapper... for mapper plugins and modules.

@rjernst rjernst merged commit 0a1a7b3 into elastic:master Sep 21, 2021
@rjernst rjernst deleted the split-packages/annotated-text branch September 21, 2021 20:00
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Sep 21, 2021
@rjernst
Fix split package in annotated text plugin (elastic#78133)
33e74af 
The annotated text mapper plugin reuses package names from server. This
commit moves the implementation classes into an annotated text package
specifically for the plugin.
@rjernst rjernst mentioned this pull request Sep 21, 2021
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
@rjernst
Fix split package in annotated text plugin (#78133) (#78143)
3877282 
The annotated text mapper plugin reuses package names from server. This
commit moves the implementation classes into an annotated text package
specifically for the plugin.
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

Assignees
No one assigned
Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rjernst @elasticmachine @elasticsearchmachine @jtibshirani @jakelandis