Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XCombinedFieldQuery workaround #77978

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Remove XCombinedFieldQuery workaround #77978

merged 1 commit into from
Sep 20, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 17, 2021 •
edited
Loading

This change removes the XCombinedFieldQuery workaround introduced in #74678 as the fix is integrated into Lucene 8.10.

Relates #74678

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v7.16.0 labels Sep 17, 2021
@dnhatn dnhatn marked this pull request as ready for review September 17, 2021 14:51
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn mentioned this pull request Sep 17, 2021
Merged
ChrisHegarty
ChrisHegarty approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jtibshirani
jtibshirani approved these changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, thanks @dnhatn.

@dnhatn
Copy link
Member Author

dnhatn commented Sep 20, 2021

@ChrisHegarty @jtibshirani Thanks for reviews.

@dnhatn dnhatn merged commit e8274c2 into elastic:master Sep 20, 2021
@dnhatn dnhatn deleted the remove-xcombined-query branch September 20, 2021 02:58
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Sep 20, 2021
@dnhatn
Remove XCombinedFieldQuery (elastic#77978)
3ec3822 
This change removes the XCombinedFieldQuery workaround introduced
in elastic#74678 as the fix is integrated into Lucene 8.10.

Relates elastic#74678
@dnhatn dnhatn mentioned this pull request Sep 20, 2021
Merged
elasticsearchmachine pushed a commit that referenced this pull request Sep 20, 2021
@dnhatn
Remove XCombinedFieldQuery (#77978) (#77985)
df9bcc3 
This change removes the XCombinedFieldQuery workaround introduced
in #74678 as the fix is integrated into Lucene 8.10.

Relates #74678
@ChrisHegarty ChrisHegarty added the modularization Java Modules related label Sep 20, 2021
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@jtibshirani jtibshirani jtibshirani approved these changes

@cbuescher cbuescher Awaiting requested review from cbuescher

Assignees
No one assigned
Labels
modularization Java Modules related >non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnhatn @elasticmachine @jtibshirani @ChrisHegarty @jakelandis @elasticsearchmachine