Remove superfluous lucene PostingFormat service configuration #81049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnascotia
added
>refactoring
modularization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the
org.apache.lucene.codecs.PostingsFormatservice configuration file from elasticsearch server. The service implementation is part of lucene, and already configured by Lucene itself, see here.It would appear likely that this service configuration file was added a some point in the past to workaround an issue where Lucene was not configuring the service itself, but I see no reason to keep this now. In fact, the declaration of a service implementation outside of the module (server in this case) raises an error when moving to Java modules.
relates #78166