Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split package with org.apache.lucene.index.OneMergeHelper #78601

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Oct 4, 2021

With LUCENE-10118 integrated, we can now remove the package
-private dependency with org.apache.lucene.index.OneMergeHelper, and
intercept the info/log messages coming from merge threads.

This change alters the logging a little, but the fundamental information
captured remains more or less the same. It is worth noting that since
the merges occur asynconously, the actual post-merge statistics are best
captured when the merge thread completes its operation - which is the
case with the change in this PR.

relates (#78166)

@ChrisHegarty ChrisHegarty added v8.0.0 modularization Java Modules related labels Oct 4, 2021
@ChrisHegarty ChrisHegarty self-assigned this Oct 4, 2021
@ChrisHegarty ChrisHegarty changed the title Fix split package with OneMergeHelper Fix split package with org.apache.lucene.index.OneMergeHelper Oct 4, 2021
@ChrisHegarty ChrisHegarty requested a review from rjernst October 4, 2021 14:51
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty merged commit 0ca3d12 into elastic:master Oct 5, 2021
@ChrisHegarty ChrisHegarty deleted the onemerge branch October 5, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modularization Java Modules related v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants