Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split packages in external test modules #78136

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 21, 2021

The external test modules are plugins which provide extra test
functionality in snapshot builds. These are independent Elasticsearch
plugins added as modules. They currently share package names with
server. This commit moves them each into their own java package name.

The external test modules are plugins which provide extra test
functionality in snapshot builds. These are independent Elasticsearch
plugins added as modules. They currently share package names with
server. This commit moves them each into their own java package name.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@rjernst
Copy link
Member Author

rjernst commented Sep 21, 2021

@elasticmachine update branch

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit eb147ab into elastic:master Sep 21, 2021
@rjernst rjernst deleted the split-packages/test-modules branch September 21, 2021 20:00
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Sep 21, 2021
The external test modules are plugins which provide extra test
functionality in snapshot builds. These are independent Elasticsearch
plugins added as modules. They currently share package names with
server. This commit moves them each into their own java package name.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
The external test modules are plugins which provide extra test
functionality in snapshot builds. These are independent Elasticsearch
plugins added as modules. They currently share package names with
server. This commit moves them each into their own java package name.
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants