fixed draft issue

[Bhavya-egov]

Summary by CodeRabbit

• New Features

  • Enhanced configuration of delivery cycles for improved user interaction.
  • Dynamic management of tab and delivery data in the DeliverySetup component.
  • New context for managing campaign data.

• Bug Fixes

  • Improved handling of state updates to prevent excessive triggering of callbacks.

• Improvements

  • Optimized caching behavior for delivery configuration data.
  • Refined navigation logic within the CycleConfiguration component.
  • Enhanced responsiveness of the DeliverySetup component to user input and data changes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

This pull request introduces several modifications to the CycleConfiguration.js and index.js files within the campaign manager module. Key changes include enhancements to the delivery cycle configuration logic, the introduction of a new action type in the reducer, and updates to the useCustomMDMS hook to manage caching behavior. Additionally, the DeliverySetup component has been refined to dynamically handle delivery rules and improve user interaction responsiveness. Overall, the changes aim to enhance state management and user experience within the delivery configuration components.

Changes

File	Change Summary
.../CycleConfiguration.js	- Clarified logic for isDisable property. - Added "RELOAD" action type to reducer for state initialization. - Updated useCustomMDMS hook with staleTime and cacheTime set to 0. - Adjusted useEffect hooks for state reloading. - Refined updateCycle and updateDelivery functions for input validation. - Modified onStepClick for improved navigation.
.../deliveryRule/index.js	- Added staleTime and cacheTime set to 0 in useCustomMDMS hook. - Updated select function to use getDeliveryConfig utility. - Altered generateTabsData for dynamic tab and delivery management. - Modified campaignDataReducer for new actions. - Limited onSelect callback triggers and managed loading state with a Loader component.

Possibly related PRs

• HCMPRE-700, HCMPRE-701 and HCMPRE-741 #1471: The changes in the DeliverySetup component in index.js include updates to the useCustomMDMS hook and the introduction of the getDeliveryConfig function, which are also relevant to the changes made in the CycleConfiguration.js file regarding delivery configurations.
• fixed summary and campaign creation #1479: The modifications in CampaignSummary.js involve restructuring delivery data handling, which aligns with the updates made in CycleConfiguration.js that enhance the management of delivery configurations.
• project type config simplified #1539: The changes in CampaignSummary.js regarding the restructuring of delivery data and the introduction of new utility functions are related to the updates in CycleConfiguration.js, which also focus on improving delivery configuration handling.
• fixed NA issue of summary #1681: The updates in SetupCampaign.js that enhance the handling of campaign cycle configuration and delivery data restructuring are directly related to the changes in CycleConfiguration.js, which also focus on managing delivery configurations effectively.

Suggested reviewers

• jagankumar-egov
• nipunarora-eGov

🐇 "In the fields where cycles spin,
Delivery rules, let’s begin!
With caching tweaks and states anew,
Our setup's bright, our paths are true.
Hopping through the code we cheer,
For smoother flows, we hold so dear!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range comments (6)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CycleConfiguration.js (3)

Line range hint 144-150: Refactor effect hook to prevent potential re-renders.

The current implementation:

• Has no dependency array, causing it to run on every render
• Uses a counter to artificially limit executions
• Could lead to unnecessary state updates

Consider using a proper dependency array or useCallback for the onSelect handler.

-  useEffect(() => {
-    if (executionCount < 5) {
-      onSelect("cycleConfigure", state);
-      setExecutionCount((prevCount) => prevCount + 1);
-    }
-  });
+  const debouncedOnSelect = useCallback(
+    debounce((state) => {
+      onSelect("cycleConfigure", state);
+    }, 300),
+    []
+  );
+
+  useEffect(() => {
+    debouncedOnSelect(state);
+  }, [state]);

---

Line range hint 152-167: Simplify and strengthen input validation logic.

The current validation in updateCycle and updateDelivery has:

• Redundant checks for both direct values and event values
• Mixed handling of different input types
• Unclear validation rules

-  const updateCycle = (d) => {
-    if (d === 0 || d > 5) return;
-    if (Number(d?.target?.value) === 0 || Number(d?.target?.value) > 5) return;
-    dispatch({ type: "UPDATE_CYCLE", payload: d?.target?.value ? Number(d?.target?.value) : d?.target?.value === "" ? d.target.value : d });
-  };
+  const validateInput = (value) => {
+    const numValue = Number(value);
+    return !isNaN(numValue) && numValue > 0 && numValue <= 5;
+  };
+
+  const updateCycle = (input) => {
+    const value = input?.target?.value ?? input;
+    if (value === "" || validateInput(value)) {
+      dispatch({ 
+        type: "UPDATE_CYCLE", 
+        payload: value === "" ? value : Number(value)
+      });
+    }
+  };

---

Line range hint 187-194: Improve step navigation maintainability.

The current implementation uses magic numbers for step navigation, which makes the code harder to maintain and understand.

+  const STEP_KEYS = {
+    PREVIOUS: 7,
+    CURRENT: 8,
+    NEXT: 9
+  };
+
   const onStepClick = (currentStep) => {
-    if(currentStep === 0){
-      setKey(7);
-    }
-    else if(currentStep === 2) setKey(9);
-    else setKey(8);
+    const stepMapping = {
+      0: STEP_KEYS.PREVIOUS,
+      1: STEP_KEYS.CURRENT,
+      2: STEP_KEYS.NEXT
+    };
+    setKey(stepMapping[currentStep] ?? STEP_KEYS.CURRENT);
   };

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (3)

Line range hint 38-260: Refactor generateTabsData to improve readability and maintainability.

The generateTabsData function has become quite complex due to the dynamic handling of tabs, sub-tabs, and delivery rules based on the project type. Consider breaking it down into smaller, more focused functions to improve readability and maintainability.

Some suggestions:

• Extract the logic for generating delivery rules based on the project type into separate functions.
• Use more descriptive variable names to enhance code clarity.
• Add comments to explain complex logic or edge cases.
• Consider using a more declarative approach, such as object mapping, to simplify the code structure.

By refactoring this function, it will be easier to understand, modify, and extend in the future.

---

Line range hint 262-354: Ensure proper handling of all action types in the reducer.

The campaignDataReducer function has been updated to handle new action types such as ADD_DELIVERY_RULE, REMOVE_DELIVERY_RULE, and updates to attributes and products. Each case in the reducer should be carefully reviewed to ensure that the state is being updated correctly based on the corresponding action.

Pay attention to the following:

• Consistency in updating the state across different action types.
• Proper handling of edge cases and potential null or undefined values.
• Maintaining the correct structure of the state object.
• Avoiding unintended side effects or mutations of the state.

Additionally, consider adding test cases to cover the different action types and their expected state updates to ensure the reducer function behaves as intended.

---

Line range hint 360-361: Consider a more descriptive name for executionCount.

The variable name executionCount doesn't clearly convey its purpose. Consider using a more descriptive name that indicates why this count is being used and what it represents.

For example, if it's used to limit the number of times the onSelect callback is triggered during the initial render, you could name it something like initialRenderCount or onSelectTriggerCount.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between a3d07f5 and 78c12d1.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CycleConfiguration.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CycleConfiguration.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (1)

Pattern **/*.js: check

🔇 Additional comments (8)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (8)

Line range hint 356-359: LGTM!

The usage of the useReducer hook with the campaignDataReducer function and the initial state generated by generateTabsData looks good. It provides a centralized way to manage the state of the campaign data and handle different actions to update the state.

---

Line range hint 363-369: Verify the impact of dispatching GENERATE_CAMPAIGN_DATA on every cycleData change.

The useEffect hook is dispatching the GENERATE_CAMPAIGN_DATA action whenever cycleData changes. This will regenerate the campaign data based on the updated cycleData.

Ensure that this behavior is intended and doesn't lead to any unexpected side effects or performance issues. Consider the following:

• Is it necessary to regenerate the entire campaign data on every cycleData change?
• Are there any specific properties within cycleData that should trigger the regeneration?
• Can the regeneration be optimized or debounced to avoid unnecessary re-renders?

Test the component thoroughly to verify that the campaign data is being updated correctly and efficiently in response to cycleData changes.

---

Line range hint 371-373: LGTM!

Triggering the onSelect callback whenever the campaignData changes is a good way to keep the parent component informed about the updated data. This allows the parent component to react to changes in the campaign data and perform any necessary actions.

---

Line range hint 375-380: Verify the purpose and necessity of the executionCount limit.

The useEffect hook is triggering the onSelect callback with the campaignData until the executionCount reaches 5. This seems to be a mechanism to limit the number of times the callback is triggered during the initial render.

However, it's important to verify the purpose and necessity of this limit:

• Why is the limit set to 5 specifically? Is there a reason behind this number?
• Is it necessary to trigger the callback multiple times during the initial render?
• Are there any potential issues or inconsistencies that could arise from this approach?

Consider reviewing the requirements and design decisions behind this implementation to ensure it aligns with the intended behavior and doesn't introduce any unintended consequences.

---

Line range hint 382-385: LGTM!

Rendering the Loader component while deliveryConfigLoading is true is a good way to provide visual feedback to the user indicating that the data is being loaded. This enhances the user experience by clearly communicating the loading state of the component.

---

Line range hint 386-400: LGTM!

The CycleContext.Provider is being used to provide the campaignData, dispatchCampaignData, and filteredDeliveryConfig values to its children components. This is a good way to share data and functionality across multiple components without the need for prop drilling.

The MultiTab component is being rendered as a child of the CycleContext.Provider, allowing it to access the provided values using the useContext hook.

The component structure and usage of the context provider look good.

---

33-36: Ensure consistent usage of getDeliveryConfig utility.

The select function within the useCustomMDMS hook has been updated to utilize the getDeliveryConfig utility for processing the fetched data based on the selected project type. This change aligns with similar updates in the CycleConfiguration.js file.

Verify that the getDeliveryConfig utility is being used consistently across the codebase to ensure data consistency and maintainability.

#!/bin/bash
# Description: Verify consistent usage of `getDeliveryConfig` utility.

# Test: Search for usage of `getDeliveryConfig`. Expect: Consistent usage across files.
ast-grep --pattern $'getDeliveryConfig($_)'

---

29-31: Verify the impact of setting staleTime and cacheTime to 0.

Setting both staleTime and cacheTime to 0 in the useCustomMDMS hook will cause the data to be fetched from the server on every render, without any caching. This can lead to unnecessary network requests and slower performance.

Consider adjusting these values based on your specific requirements. If the data doesn't change frequently, you can increase the staleTime to avoid fetching the same data repeatedly. If you want to cache the data for a certain period, you can set an appropriate cacheTime value.