qquickfix

[nabeelmd-eGov]

• added serving facility
• form composer action bar fix
• plan inbox assignee fix
• formula and assumption refresh issue
• action bar hidden fixes, session fixes
• fixes
• fix

Choose the appropriate template for your PR:

• Feature PR
• Bugfix PR
• Release PR

Summary by CodeRabbit

• New Features

  • Enhanced row selection and data display in the Plan Inbox component.
  • Added a new column for "INBOX_STATUSLOGS" in the data table.
  • Implemented warning notifications for users when no boundaries are selected during searches.
  • Improved responsiveness to URL changes in the Setup Microplan component.

• Bug Fixes

  • Refined logic for managing selected rows and workflow updates.

• Chores

  • Updated event listeners for better handling of URL changes and state updates.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request encompass modifications to three main files: PlanInbox.js, SetupMicroplan.js, and utilities.js. In PlanInbox.js, the logic for handling selected rows and displaying data has been updated, including the introduction of a new column and improved user feedback mechanisms. SetupMicroplan.js sees enhancements in state management related to URL parameters and custom event handling. Lastly, utilities.js has been adjusted to improve the updateUrlParams function by dispatching a custom event upon URL changes.

Changes

File	Change Summary
.../PlanInbox.js	Updated logic for selected rows, added "INBOX_STATUSLOGS" column, refined state management, improved user feedback in onSearch.
.../SetupMicroplan.js	Removed a destructured variable, added new state variables, enhanced URL change handling with custom events, and adjusted useEffect hooks.
.../utilities.js	Modified updateUrlParams to dispatch a "urlChanged" event after updating URL parameters.

Possibly related PRs

• Vertical stepper implemenetation #1441: Relates to UI improvements in PlanInbox.js.
• fixes #1466: Discusses UI fixes that may enhance user experience.
• Mp assumptions #1477: Focuses on assumptions management, potentially linked to row handling changes.
• User Token cache remove for multiroottenant and css fix #1506: Covers overall UI and functionality improvements.
• Formula Screen #1599: Connects to formula management and user feedback enhancements.
• added jurisdictions in facility serach and updated popinbox #1602: Discusses UI interaction improvements.
• Added action bar for pop inbox screen #1622: Relates to action bar improvements.
• planInbox console #1623: Focuses on fixes and improvements in user interaction.
• clearing session appropriately and updated workflow #1632: Discusses session management improvements.
• Finalise Action for Facility Catchment + Validations #1642: Covers action bar improvements.
• Added condition based rendering of edit column #1657: Relates to condition-based rendering improvements.
• Demo2 issue fixes #1663: Discusses bug fixes.
• draft issue fix, table reload fix, table no data fix #1664: Connects to additional bug fixes.
• DEMO UI Bug fixes #1665: Relates to further bug fixes.
• updated pending for validation for default in filter card #1666: Discusses filter updates.
• MICROPAN DRAFT ISSUE #1669: Covers additional bug fixes.
• Tab issue #1674: Relates to tab visibility improvements.
• Adhoc user #1675: Discusses further bug fixes.
• my microplan localisation, css fixes #1685: Connects to CSS fixes.
• myMicroplanFixes #1713: Relates to bug fixes.
• Microplan name update #1821: Discusses microplan name updates.
• Internal demo fixes #1827: Covers internal demo fixes.
• Updated activity selection screen to have view also #1830: Relates to activity selection updates.
• PO finding fixes #1843: Discusses various fixes.
• Plan Inbox patch fix #1847: Connects to patch fixes.
• Formcomposer action bar fixes #1862: Relates to action bar fixes.
• fixes #1869: Discusses additional fixes.

Suggested reviewers

• nipunarora-eGov

🐇 "In the Plan Inbox, rows now shine,
With status logs, everything's fine.
URL changes dance, events in a whirl,
State updates flow, watch the data twirl!
A hop and a skip in the code we delight,
Enhancements abound, oh what a sight!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 7

🧹 Outside diff range comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Line range hint 1-797: Consider breaking down the component for better maintainability

The component is handling multiple responsibilities including:

• State management for filters, selections, and workflow
• Data fetching and transformation
• Complex UI rendering
• Business logic for workflow actions

Consider:

1. Extracting workflow logic into a separate service
2. Creating custom hooks for data fetching and state management
3. Breaking down into smaller, focused components

This would improve:

• Code maintainability
• Testing capabilities
• Reusability
• Performance through better memoization opportunities

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Line range hint 225-228: Use boolean values for isLastVerticalStep checks

The checks for isLastVerticalStep === "true" and isFormulaLastVerticalStep === "true" compare strings. To improve code clarity and prevent potential bugs, consider parsing these values as booleans when setting the state.

Modify the state initializers to parse the values as booleans:

return searchParams.get("isLastVerticalStep") === "true";

Then, you can compare them directly:

- if (isLastVerticalStep === "true")
+ if (isLastVerticalStep)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between ddf3225 and 77260f7.

📒 Files selected for processing (3)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (2 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PlanInbox.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/utils/utilities.js (1)

Pattern **/*.js: check

🔇 Additional comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SetupMicroplan.js (1)

Line range hint 218-223: Confirm session data deletion on first step

In the onSecondayActionClick function, when currentKey === 1, session storage data like MICROPLAN_DATA, HYPOTHESIS_DATA, and FORMULA_DATA are deleted. Ensure that this behavior is intentional and does not inadvertently disrupt the user experience by deleting important data prematurely.

Please confirm that deleting these session variables at this point is desired and won't lead to data loss.

reviewed, urgent changes

[nipunarora-eGov]

@nabeelmd-eGov directly use queryParams while setting the state