width fix for module card #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request includes updates to HTML and SCSS files within the health micro UI component. Specifically, the stylesheet link in two HTML files has been modified to reference a new version of the CSS file for Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range comments (2)
health/micro-ui/web/public/index.html (2)
Line range hint
9-13: Consider adding Subresource Integrity (SRI) hashesThe CSS files loaded from unpkg.com don't include integrity hashes. This could pose security risks as the content could be tampered with without detection.
Example implementation:
- <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> - <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> - <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" /> + <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + integrity_no="sha384-[generated-hash]" crossorigin="anonymous" /> + <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + integrity_no="sha384-[generated-hash]" crossorigin="anonymous" /> + <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + integrity_no="sha384-[generated-hash]" crossorigin="anonymous" />
Line range hint
9-13: Consider performance optimizations for CSS deliveryMultiple CSS files are being loaded from unpkg.com which could impact initial page load performance. Consider:
- Bundling these CSS files together
- Self-hosting the files
- Adding a local fallback in case the CDN is unavailable
Example implementation with local fallback:
+ <!-- Primary CDN sources with local fallbacks --> <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + onerror="this.onerror=null;this.href='/css/digit-ui-css.css';" /> <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + onerror="this.onerror=null;this.href='/css/digit-ui-components-css.css';" /> <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" + onerror="this.onerror=null;this.href='/css/digit-ui-health-css.css';" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
⛔ Files ignored due to path filters (1)
health/micro-ui/web/micro-ui-internals/packages/css/package.jsonis excluded by!**/*.json
📒 Files selected for processing (3)
health/micro-ui/web/micro-ui-internals/example/public/index.html(1 hunks)health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/index.scss(1 hunks)health/micro-ui/web/public/index.html(1 hunks)
🔇 Additional comments (1)
health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/index.scss (1)
862-865: LGTM! Consider verifying responsive behavior.
The addition of min-width: fit-content should help resolve width issues with the module card. However, since this affects layout:
- Please verify the fix works well across different screen sizes and device widths
- Consider adding a comment explaining the purpose of these classes for future maintenance
nipunarora-eGov
approved these changes
Nov 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose the appropriate template for your PR:
Summary by CodeRabbit