Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility pop up fix #1872

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Facility pop up fix #1872

merged 5 commits into from
Nov 21, 2024

Conversation

rachana-egov
Copy link

@rachana-egov rachana-egov commented Nov 21, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new mutation configuration for searching plan facilities.
    • Enhanced assignment/unassignment logic to ensure updated facility details are fetched post-operation.
  • Bug Fixes

    • Improved error handling with toast notifications for failed updates.
  • User Experience Improvements

    • UI now reflects the most current state of facility details after assignment or unassignment actions.

@rachana-egov rachana-egov requested a review from a team as a code owner November 21, 2024 12:30
Copy link
Contributor

coderabbitai bot commented Nov 21, 2024

📝 Walkthrough

Walkthrough

The changes in FacilityPopup.js introduce a new mutation configuration for searching plan facilities and modify the assignment/unassignment logic. A new mutation configuration, planFacilitySearchMutaionConfig, is added to fetch facility details based on the facility ID and current microplan ID. The handleAssignUnassign function is updated to include a search call after assignment or unassignment, ensuring data consistency. Enhanced error handling provides feedback via toast notifications, and the success callback now searches for updated facility details to reflect the current state in the UI.

Changes

File Change Summary
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js - Added new mutation configuration planFacilitySearchMutaionConfig for fetching facility details.
- Updated handleAssignUnassign to include a search call after assignment/unassignment.
- Enhanced error handling in the onError callback with toast notifications.
- Updated success callback to search for updated facility details.

Possibly related PRs

  • Changes regarding facility catchment popup #1741: Modifies the FacilityPopup component to include an updateDetails prop, relevant to updates in the handleAssignUnassign function.
  • Facility mapper #1590: Enhances functionality and state management in the FacilityPopup component, aligning with the main PR's modifications.
  • Facility data fix #1829: Adds a new case for MICROPLAN_FACILITY_SERVINGPOPULATION in the additionalCustomizations method, related to facility data handling.

Suggested reviewers

  • nipunarora-eGov

🐇 In the popup where facilities play,
New searches bloom, come what may.
Assign and unassign, with a twist,
Updated details, none can resist!
Toasts for errors, a friendly cheer,
In our microplan, all is clear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 3c0f86f and 124bdb1.

📒 Files selected for processing (1)
  • health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1)

Pattern **/*.js: check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants